Patchwork [4,of,6] crecord: remove skipfolded keyword argument from patchnode.previtem()

login
register
mail settings
Submitter Anton Shestakov
Date May 5, 2016, 1:54 p.m.
Message ID <e4e9dd44a5c6bab85e0a.1462456444@neuro>
Download mbox | patch
Permalink /patch/14919/
State Accepted
Headers show

Comments

Anton Shestakov - May 5, 2016, 1:54 p.m.
# HG changeset patch
# User Anton Shestakov <av6@dwimlabs.net>
# Date 1462443205 -28800
#      Thu May 05 18:13:25 2016 +0800
# Node ID e4e9dd44a5c6bab85e0a132e3c5c5cfad9b7e56b
# Parent  72e6808cd0cb779f6f90d4b9a9c568d5e6c6fb1d
crecord: remove skipfolded keyword argument from patchnode.previtem()

It wasn't used, it wasn't implemeneted. Probably was a copy-paste bonus from
patchnode.nextitem()
timeless - May 5, 2016, 5:30 p.m.
On Thu, May 5, 2016 at 9:54 AM, Anton Shestakov <av6@dwimlabs.net> wrote:
> implemeneted

sp :)

Patch

diff --git a/mercurial/crecord.py b/mercurial/crecord.py
--- a/mercurial/crecord.py
+++ b/mercurial/crecord.py
@@ -164,7 +164,7 @@  class patchnode(object):
             except AttributeError: # parent and/or grandparent was None
                 return None
 
-    def previtem(self, constrainlevel=True, skipfolded=True):
+    def previtem(self, constrainlevel=True):
         """
         If constrainLevel == True, return the closest previous item
         of the same type where there are no items of different types between
@@ -174,10 +174,6 @@  class patchnode(object):
         closest to this item, regardless of item's type (header, hunk, or
         HunkLine).
 
-        If skipFolded == True, and the current item is folded, then the items
-        that are hidden due to folding will be skipped when determining the
-        next item.
-
         If it is not possible to get the previous item, return None.
         """
         if constrainlevel: