Patchwork [1,of,2,STABLE,V2] revsets: remove incorrect doc line

login
register
mail settings
Submitter Sean Farley
Date April 27, 2016, 9:16 p.m.
Message ID <c94d5bcf19875b7b1b04.1461791784@laptop.office.atlassian.com>
Download mbox | patch
Permalink /patch/14816/
State Changes Requested
Headers show

Comments

Sean Farley - April 27, 2016, 9:16 p.m.
# HG changeset patch
# User Sean Farley <sean@farley.io>
# Date 1461790929 25200
#      Wed Apr 27 14:02:09 2016 -0700
# Branch stable
# Node ID c94d5bcf19875b7b1b04ade9ad2bfb04f80ef1ae
# Parent  cfcd065cae29673c180892ae692e986661a4adc6
# EXP-Topic doc-only-revset
revsets: remove incorrect doc line
timeless - April 28, 2016, 12:34 a.m.
I don't understand. I think it's correct.

It's also parallel to:

There is a single prefix operator:

"not x"
  Changesets not in x. Short form is "! x".

(Which is slightly inaccurate, s/operator/operation/ -- there are two
operators: `not`, `!`.)

On Wed, Apr 27, 2016 at 5:16 PM, Sean Farley <sean@farley.io> wrote:
> # HG changeset patch
> # User Sean Farley <sean@farley.io>
> # Date 1461790929 25200
> #      Wed Apr 27 14:02:09 2016 -0700
> # Branch stable
> # Node ID c94d5bcf19875b7b1b04ade9ad2bfb04f80ef1ae
> # Parent  cfcd065cae29673c180892ae692e986661a4adc6
> # EXP-Topic doc-only-revset
> revsets: remove incorrect doc line
>
> diff --git a/mercurial/help/revsets.txt b/mercurial/help/revsets.txt
> --- a/mercurial/help/revsets.txt
> +++ b/mercurial/help/revsets.txt
> @@ -48,12 +48,10 @@ These are the supported infix operators:
>    for n == 2, the second parent of changeset in x.
>
>  ``x~n``
>    The nth first ancestor of x; ``x~0`` is x; ``x~3`` is ``x^^^``.
>
> -There is a single postfix operator:
> -
>  ``x^``
>    Equivalent to ``x^1``, the first parent of each changeset in x.
>
>
>  The following predicates are supported:
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Yuya Nishihara - April 28, 2016, 3:20 p.m.
On Wed, 27 Apr 2016 20:34:43 -0400, timeless wrote:
> On Wed, Apr 27, 2016 at 5:16 PM, Sean Farley <sean@farley.io> wrote:
> > # HG changeset patch
> > # User Sean Farley <sean@farley.io>
> > # Date 1461790929 25200
> > #      Wed Apr 27 14:02:09 2016 -0700
> > # Branch stable
> > # Node ID c94d5bcf19875b7b1b04ade9ad2bfb04f80ef1ae
> > # Parent  cfcd065cae29673c180892ae692e986661a4adc6
> > # EXP-Topic doc-only-revset
> > revsets: remove incorrect doc line
> >
> > diff --git a/mercurial/help/revsets.txt b/mercurial/help/revsets.txt
> > --- a/mercurial/help/revsets.txt
> > +++ b/mercurial/help/revsets.txt
> > @@ -48,12 +48,10 @@ These are the supported infix operators:
> >    for n == 2, the second parent of changeset in x.
> >
> >  ``x~n``
> >    The nth first ancestor of x; ``x~0`` is x; ``x~3`` is ``x^^^``.
> >
> > -There is a single postfix operator:
> > -
> >  ``x^``
> >    Equivalent to ``x^1``, the first parent of each changeset in x.

> I don't understand. I think it's correct.
> It's also parallel to:
>
> There is a single prefix operator:

Perhaps Sean would mean "x%" is also a postfix (suffix) operator. But I
agree with timeless in that removing this sentence is inconsistent.
Sean Farley - April 28, 2016, 10:41 p.m.
Yuya Nishihara <yuya@tcha.org> writes:

> On Wed, 27 Apr 2016 20:34:43 -0400, timeless wrote:
>> On Wed, Apr 27, 2016 at 5:16 PM, Sean Farley <sean@farley.io> wrote:
>> > # HG changeset patch
>> > # User Sean Farley <sean@farley.io>
>> > # Date 1461790929 25200
>> > #      Wed Apr 27 14:02:09 2016 -0700
>> > # Branch stable
>> > # Node ID c94d5bcf19875b7b1b04ade9ad2bfb04f80ef1ae
>> > # Parent  cfcd065cae29673c180892ae692e986661a4adc6
>> > # EXP-Topic doc-only-revset
>> > revsets: remove incorrect doc line
>> >
>> > diff --git a/mercurial/help/revsets.txt b/mercurial/help/revsets.txt
>> > --- a/mercurial/help/revsets.txt
>> > +++ b/mercurial/help/revsets.txt
>> > @@ -48,12 +48,10 @@ These are the supported infix operators:
>> >    for n == 2, the second parent of changeset in x.
>> >
>> >  ``x~n``
>> >    The nth first ancestor of x; ``x~0`` is x; ``x~3`` is ``x^^^``.
>> >
>> > -There is a single postfix operator:
>> > -
>> >  ``x^``
>> >    Equivalent to ``x^1``, the first parent of each changeset in x.
>
>> I don't understand. I think it's correct.
>> It's also parallel to:
>>
>> There is a single prefix operator:
>
> Perhaps Sean would mean "x%" is also a postfix (suffix) operator. But I
> agree with timeless in that removing this sentence is inconsistent.

It was from IRC:

<mpm> "There is a single postfix operator:" <- has never been true.

Patch

diff --git a/mercurial/help/revsets.txt b/mercurial/help/revsets.txt
--- a/mercurial/help/revsets.txt
+++ b/mercurial/help/revsets.txt
@@ -48,12 +48,10 @@  These are the supported infix operators:
   for n == 2, the second parent of changeset in x.
 
 ``x~n``
   The nth first ancestor of x; ``x~0`` is x; ``x~3`` is ``x^^^``.
 
-There is a single postfix operator:
-
 ``x^``
   Equivalent to ``x^1``, the first parent of each changeset in x.
 
 
 The following predicates are supported: