Patchwork [22,of,24] convert: process subversion branch in a sorted order

login
register
mail settings
Submitter Mads Kiilerich
Date Dec. 16, 2012, 10:34 p.m.
Message ID <1a139a7c00d39c1c6db2.1355697257@localhost6.localdomain6>
Download mbox | patch
Permalink /patch/148/
State Accepted
Commit 942ecb55b1de4bcdded55b4bdc9a50547fa916ba
Headers show

Comments

Mads Kiilerich - Dec. 16, 2012, 10:34 p.m.
# HG changeset patch
# User Mads Kiilerich <mads at kiilerich.com>
# Date 1355687458 -3600
# Node ID 1a139a7c00d39c1c6db281347242cd4a46f614bd
# Parent  9620cbd6db4c07b26d6076cb6fee1aea80cf3cfc
convert: process subversion branch in a sorted order
Bryan O'Sullivan - Dec. 17, 2012, 9:10 p.m.
On Sun, Dec 16, 2012 at 2:34 PM, Mads Kiilerich <mads at kiilerich.com> wrote:

> convert: process subversion branch in a sorted order
>

Looks odd - it has no impact on test output?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121217/fa1c7080/attachment.html>

Patch

diff --git a/hgext/convert/subversion.py b/hgext/convert/subversion.py
--- a/hgext/convert/subversion.py
+++ b/hgext/convert/subversion.py
@@ -377,7 +377,7 @@ 
             rpath = self.url.strip('/')
             branchnames = svn.client.ls(rpath + '/' + quote(branches),
                                         rev, False, self.ctx)
-            for branch in branchnames.keys():
+            for branch in sorted(branchnames):
                 module = '%s/%s/%s' % (oldmodule, branches, branch)
                 if not isdir(module, self.last_changed):
                     continue