Patchwork [evolve-ext] split: rewrite the pre-split commit message

login
register
mail settings
Submitter Jordi Gutiérrez Hermoso
Date April 25, 2016, 2:33 a.m.
Message ID <9eb10a347b55721cdf84.1461551593@Iris>
Download mbox | patch
Permalink /patch/14782/
State Accepted
Delegated to: Pierre-Yves David
Headers show

Comments

Jordi Gutiérrez Hermoso - April 25, 2016, 2:33 a.m.
# HG changeset patch
# User Jordi Gutiérrez Hermoso <jordigh@octave.org>
# Date 1461551518 14400
#      Sun Apr 24 22:31:58 2016 -0400
# Node ID 9eb10a347b55721cdf8400f223a7b08507fee38e
# Parent  8e879d59b20e60e8af013a776f5e3dcc20588fcf
split: rewrite the pre-split commit message

I find this wording slightly clearer.
Sean Farley - April 25, 2016, 5:01 a.m.
Jordi Gutiérrez Hermoso <jordigh@octave.org> writes:

> # HG changeset patch
> # User Jordi Gutiérrez Hermoso <jordigh@octave.org>
> # Date 1461551518 14400
> #      Sun Apr 24 22:31:58 2016 -0400
> # Node ID 9eb10a347b55721cdf8400f223a7b08507fee38e
> # Parent  8e879d59b20e60e8af013a776f5e3dcc20588fcf
> split: rewrite the pre-split commit message
>
> I find this wording slightly clearer.
>
> diff --git a/hgext/evolve.py b/hgext/evolve.py
> --- a/hgext/evolve.py
> +++ b/hgext/evolve.py
> @@ -2910,7 +2910,8 @@ def cmdsplit(ui, repo, *revs, **opts):
>          def haschanges():
>              modified, added, removed, deleted = repo.status()[:4]
>              return modified or added or removed or deleted
> -        msg = 'HG: Please, edit the original changeset description.\n\n'
> +        msg = ("HG: This is the original pre-split commit message. "
> +               "Edit it as appropriate.\n\n")

Yeah, this sounds a little nicer to me, too.
Pierre-Yves David - May 2, 2016, 2:36 p.m.
Pushed, thanks.

On 04/25/2016 07:01 AM, Sean Farley wrote:
> Jordi Gutiérrez Hermoso <jordigh@octave.org> writes:
>
>> # HG changeset patch
>> # User Jordi Gutiérrez Hermoso <jordigh@octave.org>
>> # Date 1461551518 14400
>> #      Sun Apr 24 22:31:58 2016 -0400
>> # Node ID 9eb10a347b55721cdf8400f223a7b08507fee38e
>> # Parent  8e879d59b20e60e8af013a776f5e3dcc20588fcf
>> split: rewrite the pre-split commit message
>>
>> I find this wording slightly clearer.
>>
>> diff --git a/hgext/evolve.py b/hgext/evolve.py
>> --- a/hgext/evolve.py
>> +++ b/hgext/evolve.py
>> @@ -2910,7 +2910,8 @@ def cmdsplit(ui, repo, *revs, **opts):
>>           def haschanges():
>>               modified, added, removed, deleted = repo.status()[:4]
>>               return modified or added or removed or deleted
>> -        msg = 'HG: Please, edit the original changeset description.\n\n'
>> +        msg = ("HG: This is the original pre-split commit message. "
>> +               "Edit it as appropriate.\n\n")
> Yeah, this sounds a little nicer to me, too.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/hgext/evolve.py b/hgext/evolve.py
--- a/hgext/evolve.py
+++ b/hgext/evolve.py
@@ -2910,7 +2910,8 @@  def cmdsplit(ui, repo, *revs, **opts):
         def haschanges():
             modified, added, removed, deleted = repo.status()[:4]
             return modified or added or removed or deleted
-        msg = 'HG: Please, edit the original changeset description.\n\n'
+        msg = ("HG: This is the original pre-split commit message. "
+               "Edit it as appropriate.\n\n")
         msg += ctx.description()
         opts['message'] = msg
         opts['edit'] = True