Patchwork [5,of,5,STABLE,V2] debian: add missing netbase dependency

login
register
mail settings
Submitter Sean Farley
Date April 17, 2016, 6:14 p.m.
Message ID <1335c3d73d68b9e90d1d.1460916859@laptop.local>
Download mbox | patch
Permalink /patch/14717/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

Sean Farley - April 17, 2016, 6:14 p.m.
# HG changeset patch
# User Sean Farley <sean@farley.io>
# Date 1460914757 25200
#      Sun Apr 17 10:39:17 2016 -0700
# Branch stable
# Node ID 1335c3d73d68b9e90d1ddac5cee53781a3e0f693
# Parent  6b343d9fe46be219458e13da1de0a610f8508b75
# EXP-Topic ppa
debian: add missing netbase dependency

Apparently, some machines don't have this service (launchpad builders are one
such example). This adds the correct dependency for test-serve.t.
timeless - April 17, 2016, 9:54 p.m.
Sean Farley wrote:
> debian: add missing netbase dependency

> Apparently, some machines don't have this service (launchpad builders are one
> such example). This adds the correct dependency for test-serve.t.

this comment seems stale

> +++ b/contrib/debian/control
> + netbase,
Sean Farley - April 17, 2016, 11:38 p.m.
timeless <timeless@gmail.com> writes:

> Sean Farley wrote:
>> debian: add missing netbase dependency
>
>> Apparently, some machines don't have this service (launchpad builders are one
>> such example). This adds the correct dependency for test-serve.t.
>
> this comment seems stale

Not really? This dependency is needed for test-serve.t to run on the
launchpad builders.
Yuya Nishihara - April 18, 2016, 1:40 p.m.
On Sun, 17 Apr 2016 11:14:19 -0700, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley <sean@farley.io>
> # Date 1460914757 25200
> #      Sun Apr 17 10:39:17 2016 -0700
> # Branch stable
> # Node ID 1335c3d73d68b9e90d1ddac5cee53781a3e0f693
> # Parent  6b343d9fe46be219458e13da1de0a610f8508b75
> # EXP-Topic ppa
> debian: add missing netbase dependency

The patch 2-5 look good to me, queued them, thanks.

Patch

diff --git a/contrib/debian/control b/contrib/debian/control
--- a/contrib/debian/control
+++ b/contrib/debian/control
@@ -3,10 +3,11 @@  Section: vcs
 Priority: optional
 Maintainer: Mercurial Developers <mercurial-devel@selenic.com>
 Build-Depends:
  debhelper (>= 7),
  dh-python,
+ netbase,
  python-all,
  python-all-dev,
  python-docutils,
  zip,
  unzip