Patchwork [1,of,2] crecord: drop the extra confirmation screen

login
register
mail settings
Submitter Pierre-Yves David
Date April 14, 2016, 9:08 a.m.
Message ID <e0fa2da7f3c18a2ba980.1460624883@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/14606/
State Accepted
Delegated to: Matt Mackall
Headers show

Comments

Pierre-Yves David - April 14, 2016, 9:08 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1460622438 25200
#      Thu Apr 14 01:27:18 2016 -0700
# Node ID e0fa2da7f3c18a2ba980fdfe829a322c7e88f446
# Parent  8d398155bfda3a98e664af74096f0e405cc7dd09
crecord: drop the extra confirmation screen

The commit confirmation is not very useful -- it gives no way to view what you
have selected, so you're blindly choosing whether to proceed or not, and it adds
a lot of unnecessary friction to committing. In addition, we now have a working
'review' choice for those who really want to review the final change.

Ryan McElroy initially submitted a config option to make this optional, but we
never saw a V2. However as the freeze is near and curses have never been
officially out of the door, I think it is worth skipping the config and trying
getting it right for this release.

Patch

diff -r 8d398155bfda -r e0fa2da7f3c1 mercurial/crecord.py
--- a/mercurial/crecord.py	Mon Feb 29 22:58:15 2016 +0900
+++ b/mercurial/crecord.py	Thu Apr 14 01:27:18 2016 -0700
@@ -1600,8 +1600,7 @@ 
         elif keypressed in ['a']:
             self.toggleamend(self.opts, test)
         elif keypressed in ["c"]:
-            if self.confirmcommit():
-                return True
+            return True
         elif test and keypressed in ['X']:
             return True
         elif keypressed in ["r"]: