Patchwork [4,of,5] py3: use absolute_import in test-wireproto.py

login
register
mail settings
Submitter timeless@mozdev.org
Date April 10, 2016, 9:57 p.m.
Message ID <4b0632dccc1c8b346bff.1460325457@waste.org>
Download mbox | patch
Permalink /patch/14495/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

timeless@mozdev.org - April 10, 2016, 9:57 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1460323928 0
#      Sun Apr 10 21:32:08 2016 +0000
# Node ID 4b0632dccc1c8b346bfff5689aa75ed06a265c21
# Parent  90c4f3e3c85747e09aa7edaedb11c7e556cc8def
py3: use absolute_import in test-wireproto.py
timeless - April 10, 2016, 10:10 p.m.
The reason I did it is that I had a later commit that was adding to the list.

I think of it as "nice", because it means that later changes are only
charged for adding modules to the list instead of restructuring.

We're clearly not enforcing this yet (otherwise we'd have a test
pleading for it).

On Sun, Apr 10, 2016 at 6:08 PM, Pulkit Goyal <7895pulkit@gmail.com> wrote:
>> -from mercurial import wireproto
>> +from mercurial import (
>> +    wireproto,
>> +)
> Is it necessary to do so, because I was skipping single imports like this.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Yuya Nishihara - April 11, 2016, 2:43 p.m.
On Sun, 10 Apr 2016 16:57:37 -0500, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1460323928 0
> #      Sun Apr 10 21:32:08 2016 +0000
> # Node ID 4b0632dccc1c8b346bfff5689aa75ed06a265c21
> # Parent  90c4f3e3c85747e09aa7edaedb11c7e556cc8def
> py3: use absolute_import in test-wireproto.py

Rephrased as "use multi-line import" and queued, thanks.

> --- a/tests/test-wireproto.py
> +++ b/tests/test-wireproto.py
> @@ -1,8 +1,9 @@
>  from __future__ import absolute_import, print_function
>  
>  import StringIO
> -
> -from mercurial import wireproto
> +from mercurial import (
> +    wireproto,
> +)

Patch

diff --git a/tests/test-wireproto.py b/tests/test-wireproto.py
--- a/tests/test-wireproto.py
+++ b/tests/test-wireproto.py
@@ -1,8 +1,9 @@ 
 from __future__ import absolute_import, print_function
 
 import StringIO
-
-from mercurial import wireproto
+from mercurial import (
+    wireproto,
+)
 
 class proto(object):
     def __init__(self, args):