Patchwork [6,of,7] chg: use relative path at connect

login
register
mail settings
Submitter Pierre-Yves David
Date April 4, 2016, 3:14 a.m.
Message ID <5701DC33.7060502@ens-lyon.org>
Download mbox | patch
Permalink /patch/14330/
State Not Applicable
Headers show

Comments

Pierre-Yves David - April 4, 2016, 3:14 a.m.
On 04/03/2016 07:30 PM, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark@fb.com>
> # Date 1459736917 -3600
> #      Mon Apr 04 03:28:37 2016 +0100
> # Node ID f7c6cfae4dba1c48a63bdea1b9aa816e7f634d02
> # Parent  f5414d2b4f32431a251029ebf46f48efdd9f013c
> chg: use relative path at connect
>
> We have made chgserver use relative path at bind(), now do the same change to
> the client at connect().

This one triggers an apocalypse of crash on my testing maching (from 13 
failure to about 250)

Ive singled out the start of a simple test failure as an example.
Jun Wu - April 4, 2016, 4:01 a.m.
On 04/04/2016 04:14 AM, Pierre-Yves David wrote:
> This one triggers an apocalypse of crash on my testing maching (from 13 failure
> to about 250)
>
> Ive singled out the start of a simple test failure as an example.
>
>
> --- /home/marmoute/mercurial-testing/tests/test-graft.t
> +++ /home/marmoute/mercurial-testing/tests/test-graft.t.err
> @@ -7,838 +7,8 @@
>   Create a repo with some stuff in it:
>
>     $ hg init a
> +  \x1b[1;31mchg: abort: cannot chdir (errno = 2)\x1b[m (esc)
> +  [255]

Interesting. Thanks for catching this!

But I cannot reproduce with run-tess.py --chg test-graft.t locally.
I will think about it later.
Pierre-Yves David - April 4, 2016, 7:10 a.m.
On 04/03/2016 09:01 PM, Jun Wu wrote:
> On 04/04/2016 04:14 AM, Pierre-Yves David wrote:
>> This one triggers an apocalypse of crash on my testing maching (from
>> 13 failure
>> to about 250)
>>
>> Ive singled out the start of a simple test failure as an example.
>>
>>
>> --- /home/marmoute/mercurial-testing/tests/test-graft.t
>> +++ /home/marmoute/mercurial-testing/tests/test-graft.t.err
>> @@ -7,838 +7,8 @@
>>   Create a repo with some stuff in it:
>>
>>     $ hg init a
>> +  \x1b[1;31mchg: abort: cannot chdir (errno = 2)\x1b[m (esc)
>> +  [255]
>
> Interesting. Thanks for catching this!
>
> But I cannot reproduce with run-tess.py --chg test-graft.t locally.
> I will think about it later.

Could be an endianness issue, this is a power8 machine.

Patch

--- /home/marmoute/mercurial-testing/tests/test-graft.t
+++ /home/marmoute/mercurial-testing/tests/test-graft.t.err
@@ -7,838 +7,8 @@ 
  Create a repo with some stuff in it:

    $ hg init a
+  \x1b[1;31mchg: abort: cannot chdir (errno = 2)\x1b[m (esc)
+  [255]
    $ cd a
+  $TESTTMP.sh: line 11: cd: a: No such file or directory
    $ echo a > a
-  $ echo a > d
-  $ echo a > e
-  $ hg ci -qAm0
-  $ echo b > a
-  $ hg ci -m1 -u bar
-  $ hg mv a b

Cheers,

-- 
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel