Patchwork bundle: remove obsolete (and duplicate) comment

login
register
mail settings
Submitter via Mercurial-devel
Date March 29, 2016, 5:45 p.m.
Message ID <4530a43ebf96e21faef9.1459273505@martinvonz.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/14149/
State Accepted
Headers show

Comments

via Mercurial-devel - March 29, 2016, 5:45 p.m.
# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1459272065 25200
#      Tue Mar 29 10:21:05 2016 -0700
# Node ID 4530a43ebf96e21faef964b76078257a0053d8df
# Parent  ff0d3b6b287f89594bd8d0308fe2810d2a18ea01
bundle: remove obsolete (and duplicate) comment

Change 1e28ec9744bf (changegroup: move chunk extraction into a
getchunks method of unbundle10, 2014-04-10) extracted some code to a
getchunks() method and copied a comment about the changegroup format
to the new method. The copy that remains in the old place, doesn't
make much sense there, so let's remove it.
Pierre-Yves David - March 29, 2016, 6:11 p.m.
On 03/29/2016 10:45 AM, Martin von Zweigbergk via Mercurial-devel wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz@google.com>
> # Date 1459272065 25200
> #      Tue Mar 29 10:21:05 2016 -0700
> # Node ID 4530a43ebf96e21faef964b76078257a0053d8df
> # Parent  ff0d3b6b287f89594bd8d0308fe2810d2a18ea01
> bundle: remove obsolete (and duplicate) comment

Pushed, thanks

Patch

diff -r ff0d3b6b287f -r 4530a43ebf96 mercurial/bundle2.py
--- a/mercurial/bundle2.py	Tue Mar 29 12:29:00 2016 -0500
+++ b/mercurial/bundle2.py	Tue Mar 29 10:21:05 2016 -0700
@@ -1314,10 +1314,6 @@ 
 
     # parse the changegroup data, otherwise we will block
     # in case of sshrepo because we don't know the end of the stream
-
-    # an empty chunkgroup is the end of the changegroup
-    # a changegroup has at least 2 chunkgroups (changelog and manifest).
-    # after that, an empty chunkgroup is the end of the changegroup
     return changegroup.writechunks(ui, chunkiter, filename, vfs=vfs)
 
 @parthandler('changegroup', ('version', 'nbchanges', 'treemanifest'))