Patchwork [V2] record: deprecate the extension

login
register
mail settings
Submitter Pierre-Yves David
Date March 28, 2016, 10:15 p.m.
Message ID <1e21cde56375d1350d6d.1459203325@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/14115/
State Accepted
Headers show

Comments

Pierre-Yves David - March 28, 2016, 10:15 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1459194656 25200
#      Mon Mar 28 12:50:56 2016 -0700
# Node ID 1e21cde56375d1350d6dda664a8bf10fd0b49a8e
# Parent  5474dc73680f96e79ae3c255fb01b7943b2fc2d1
# EXP-Topic extensions.cleanup
# Available At http://mercurial-scm.org/repo/users/marmoute/mercurial/
#              hg pull http://mercurial-scm.org/repo/users/marmoute/mercurial/ -r 1e21cde56375
record: deprecate the extension

The feature has been moved into core behind the -i flag. We can safely
deprecated the extension and point people at the --interactive flag in core.
Yuya Nishihara - March 30, 2016, 1:41 p.m.
On Mon, 28 Mar 2016 15:15:25 -0700, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1459194656 25200
> #      Mon Mar 28 12:50:56 2016 -0700
> # Node ID 1e21cde56375d1350d6dda664a8bf10fd0b49a8e
> # Parent  5474dc73680f96e79ae3c255fb01b7943b2fc2d1
> # EXP-Topic extensions.cleanup
> # Available At http://mercurial-scm.org/repo/users/marmoute/mercurial/
> #              hg pull http://mercurial-scm.org/repo/users/marmoute/mercurial/ -r 1e21cde56375
> record: deprecate the extension

Looks good to me. Queued, thanks.

Patch

diff --git a/hgext/record.py b/hgext/record.py
--- a/hgext/record.py
+++ b/hgext/record.py
@@ -3,11 +3,15 @@ 
 # Copyright 2007 Bryan O'Sullivan <bos@serpentine.com>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
-'''commands to interactively select changes for commit/qrefresh'''
+'''commands to interactively select changes for commit/qrefresh (DEPRECATED)
+
+The feature provided by this extension has been moved into core Mercurial as
+:hg:`commit --interactive`.'''
+
 from __future__ import absolute_import
 
 from mercurial import (
     cmdutil,
     commands,
diff --git a/tests/test-help.t b/tests/test-help.t
--- a/tests/test-help.t
+++ b/tests/test-help.t
@@ -270,12 +270,10 @@  Test extension help:
        notify        hooks for sending email push notifications
        pager         browse command output with an external pager
        patchbomb     command to send changesets as (a series of) patch emails
        purge         command to delete untracked files from the working
                      directory
-       record        commands to interactively select changes for
-                     commit/qrefresh
        relink        recreates hardlinks between repository clones
        schemes       extend schemes with shortcuts to repository swarms
        share         share a common history between several working directories
        shelve        save and restore changes to the working directory
        strip         strip changesets and their descendants from history
diff --git a/tests/test-qrecord.t b/tests/test-qrecord.t
--- a/tests/test-qrecord.t
+++ b/tests/test-qrecord.t
@@ -5,20 +5,21 @@  Create configuration
 
 help record (no record)
 
   $ hg help record
   record extension - commands to interactively select changes for
-  commit/qrefresh
+  commit/qrefresh (DEPRECATED)
   
   (use "hg help extensions" for information on enabling extensions)
 
 help qrecord (no record)
 
   $ hg help qrecord
   'qrecord' is provided by the following extension:
   
       record        commands to interactively select changes for commit/qrefresh
+                    (DEPRECATED)
   
   (use "hg help extensions" for information on enabling extensions)
 
   $ echo "[extensions]"     >> $HGRCPATH
   $ echo "record="          >> $HGRCPATH
@@ -52,10 +53,12 @@  help record (record)
   
         ? - display help
   
       This command is not available when committing a merge.
   
+  (use "hg help -e record" to show help for the record extension)
+  
   options ([+] can be repeated):
   
    -A --addremove           mark new/missing files as added/removed before
                             committing
       --close-branch        mark a branch head as closed
diff --git a/tests/test-record.t b/tests/test-record.t
--- a/tests/test-record.t
+++ b/tests/test-record.t
@@ -39,10 +39,12 @@  Record help
   
         ? - display help
   
       This command is not available when committing a merge.
   
+  (use "hg help -e record" to show help for the record extension)
+  
   options ([+] can be repeated):
   
    -A --addremove           mark new/missing files as added/removed before
                             committing
       --close-branch        mark a branch head as closed