Patchwork [Bug,5156] New: test-convert-cvs.t is flaky due to a timing dependency

login
register
mail settings
Submitter mercurial-bugs@selenic.com
Date March 25, 2016, 11:58 p.m.
Message ID <bug-5156-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/14076/
State Not Applicable
Headers show

Comments

mercurial-bugs@selenic.com - March 25, 2016, 11:58 p.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=5156

            Bug ID: 5156
           Summary: test-convert-cvs.t is flaky due to a timing dependency
           Product: Mercurial
           Version: default branch
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: convert
          Assignee: bugzilla@selenic.com
          Reporter: simonfar@fb.com
                CC: durin42@gmail.com, mercurial-devel@selenic.com

If your timing is unfortunate, test-convert-cvs.t fails, as timing determines
how many cvschangesets you get. With enough runs, you get a variety of errors
like:


ERROR: test-convert-cvs.t output changed
!
Failed test-convert-cvs.t: output changed
# Ran 1 tests, 0 skipped, 0 warned, 1 failed.
python hash seed: 714002554

Patch

--- /data/users/simonfar/hg/tests/test-convert-cvs.t
+++ /data/users/simonfar/hg/tests/test-convert-cvs.t.err
@@ -303,10 +303,11 @@ 
   11 log entries
   cvslog hook: 11 entries
   creating changesets
-  8 changeset entries
-  cvschangesets hook: 8 changesets
-  sorting...
-  converting...
+  9 changeset entries
+  cvschangesets hook: 9 changesets
+  sorting...
+  converting...
+  3 ci2
   2 funny
   1 fuzzy
   0 fuzzy