Patchwork [1,of,5] filemerge: use revset notation for p1/p2 of local/other descriptions

login
register
mail settings
Submitter timeless@mozdev.org
Date March 22, 2016, 10:21 p.m.
Message ID <994882c8bff031e25365.1458685308@waste.org>
Download mbox | patch
Permalink /patch/14027/
State Superseded
Headers show

Comments

timeless@mozdev.org - March 22, 2016, 10:21 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1458174961 0
#      Thu Mar 17 00:36:01 2016 +0000
# Node ID 994882c8bff031e25365a5ebf02451eba8c6d067
# Parent  62e73d42bd141a39a576a8cfd6f1ffcf06a0b2d0
filemerge: use revset notation for p1/p2 of local/other descriptions

Patch

diff --git a/mercurial/filemerge.py b/mercurial/filemerge.py
--- a/mercurial/filemerge.py
+++ b/mercurial/filemerge.py
@@ -230,8 +230,8 @@ 
 
 @internaltool('prompt', nomerge)
 def _iprompt(repo, mynode, orig, fcd, fco, fca, toolconf):
-    """Asks the user which of the local (p1) or the other (p2) version to keep
-    as the merged version."""
+    """Asks the user which of the local `p1()` or the other `p2()` version to
+    keep as the merged version."""
     ui = repo.ui
     fd = fcd.path()
 
@@ -268,12 +268,12 @@ 
 
 @internaltool('local', nomerge)
 def _ilocal(repo, mynode, orig, fcd, fco, fca, toolconf):
-    """Uses the local (p1) version of files as the merged version."""
+    """Uses the local `p1()` version of files as the merged version."""
     return 0, fcd.isabsent()
 
 @internaltool('other', nomerge)
 def _iother(repo, mynode, orig, fcd, fco, fca, toolconf):
-    """Uses the other (p2) version of files as the merged version."""
+    """Uses the other `p2()` version of files as the merged version."""
     if fco.isabsent():
         # local changed, remote deleted -- 'deleted' picked
         repo.wvfs.unlinkpath(fcd.path())
@@ -411,7 +411,7 @@ 
 def _imergelocal(*args, **kwargs):
     """
     Like :merge, but resolve all conflicts non-interactively in favor
-    of the local (p1) changes."""
+    of the local `p1()` changes."""
     success, status = _imergeauto(localorother='local', *args, **kwargs)
     return success, status, False
 
@@ -419,7 +419,7 @@ 
 def _imergeother(*args, **kwargs):
     """
     Like :merge, but resolve all conflicts non-interactively in favor
-    of the other (p2) changes."""
+    of the other `p2()` changes."""
     success, status = _imergeauto(localorother='other', *args, **kwargs)
     return success, status, False
 
diff --git a/tests/test-help.t b/tests/test-help.t
--- a/tests/test-help.t
+++ b/tests/test-help.t
@@ -1539,7 +1539,7 @@ 
         to resolve these conflicts.
   
       ":local"
-        Uses the local (p1) version of files as the merged version.
+        Uses the local 'p1()' version of files as the merged version.
   
       ":merge"
         Uses the internal non-interactive simple merge algorithm for merging
@@ -1549,11 +1549,11 @@ 
   
       ":merge-local"
         Like :merge, but resolve all conflicts non-interactively in favor of the
-        local (p1) changes.
+        local 'p1()' changes.
   
       ":merge-other"
         Like :merge, but resolve all conflicts non-interactively in favor of the
-        other (p2) changes.
+        other 'p2()' changes.
   
       ":merge3"
         Uses the internal non-interactive simple merge algorithm for merging
@@ -1562,11 +1562,11 @@ 
         side of the merge and one for the base content.
   
       ":other"
-        Uses the other (p2) version of files as the merged version.
+        Uses the other 'p2()' version of files as the merged version.
   
       ":prompt"
-        Asks the user which of the local (p1) or the other (p2) version to keep
-        as the merged version.
+        Asks the user which of the local 'p1()' or the other 'p2()' version to
+        keep as the merged version.
   
       ":tagmerge"
         Uses the internal tag merge algorithm (experimental).