Patchwork [2,of,2] progress: update comment to reflect implementation

login
register
mail settings
Submitter timeless@mozdev.org
Date March 20, 2016, 4:56 a.m.
Message ID <bafedf8f86c4caa3d241.1458449788@waste.org>
Download mbox | patch
Permalink /patch/13978/
State Accepted
Headers show

Comments

timeless@mozdev.org - March 20, 2016, 4:56 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1458239672 0
#      Thu Mar 17 18:34:32 2016 +0000
# Node ID bafedf8f86c4caa3d2415218de5e9699873694a8
# Parent  ee34ec6c82fdfd6aee6874fa6caf96b99a73819a
progress: update comment to reflect implementation

Progress has been on by default in core for a while,
the comment was written before this happened.
Pierre-Yves David - March 20, 2016, 5:15 a.m.
On 03/19/2016 09:56 PM, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1458239672 0
> #      Thu Mar 17 18:34:32 2016 +0000
> # Node ID bafedf8f86c4caa3d2415218de5e9699873694a8
> # Parent  ee34ec6c82fdfd6aee6874fa6caf96b99a73819a
> progress: update comment to reflect implementation

Pushed to the clowncopter, thanks.

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -1004,9 +1004,8 @@ 
     def progress(self, topic, pos, item="", unit="", total=None):
         '''show a progress message
 
-        With stock hg, this is simply a debug message that is hidden
-        by default, but with extensions or GUI tools it may be
-        visible. 'topic' is the current operation, 'item' is a
+        By default a textual progress bar will be displayed if an operation
+        takes too long. 'topic' is the current operation, 'item' is a
         non-numeric marker of the current position (i.e. the currently
         in-process file), 'pos' is the current numeric position (i.e.
         revision, bytes, etc.), unit is a corresponding unit label,