Patchwork [1,of,3] crecord: rewrite a comment about filtering patches

login
register
mail settings
Submitter Jordi Gutiérrez Hermoso
Date March 18, 2016, 8:45 p.m.
Message ID <81813cad034146e59895.1458333936@Iris>
Download mbox | patch
Permalink /patch/13939/
State Accepted
Headers show

Comments

Jordi Gutiérrez Hermoso - March 18, 2016, 8:45 p.m.
# HG changeset patch
# User Jordi Gutiérrez Hermoso <jordigh@octave.org>
# Date 1458332097 14400
#      Fri Mar 18 16:14:57 2016 -0400
# Node ID 81813cad034146e598955b2b726093340a1c4c22
# Parent  ed75909c4c670a7d9db4a2bef9817a0d5f0b4d9c
crecord: rewrite a comment about filtering patches

I couldn't parse the previous version. I think the rewrite better
expresses the intent of that comment.
Pierre-Yves David - March 19, 2016, 6:49 a.m.
On 03/18/2016 01:45 PM, Jordi Gutiérrez Hermoso wrote:
> # HG changeset patch
> # User Jordi Gutiérrez Hermoso <jordigh@octave.org>
> # Date 1458332097 14400
> #      Fri Mar 18 16:14:57 2016 -0400
> # Node ID 81813cad034146e598955b2b726093340a1c4c22
> # Parent  ed75909c4c670a7d9db4a2bef9817a0d5f0b4d9c
> crecord: rewrite a comment about filtering patches

I've pushed patch 1 as obviously correct. Can you sit with Laurent 
tomorrow to find out away to test the patch?

Also, Why do we have to review the patch in an editors? isn't the 
infamous confirmation screen of crecord appropriate for that?

Patch

diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -148,7 +148,7 @@  def dorecord(ui, repo, commitfunc, cmdsu
         originaldiff = patch.diff(repo, changes=status, opts=diffopts)
         originalchunks = patch.parsepatch(originaldiff)
 
-        # 1. filter patch, so we have intending-to apply subset of it
+        # 1. filter patch, since we are intending to apply subset of it
         try:
             chunks, newopts = filterfn(ui, originalchunks)
         except patch.PatchError as err: