Patchwork tests: python executable path should always be globbed

login
register
mail settings
Submitter Danek Duvall
Date March 15, 2016, 10:54 p.m.
Message ID <c54f92f246b1d0d353d9.1458082470@smelly.us.oracle.com>
Download mbox | patch
Permalink /patch/13902/
State Accepted
Commit 4d93d73b8aecb2436bbfe9248cdfe0ef21582baf
Headers show

Comments

Danek Duvall - March 15, 2016, 10:54 p.m.
# HG changeset patch
# User Danek Duvall <danek.duvall@oracle.com>
# Date 1458082257 25200
#      Tue Mar 15 15:50:57 2016 -0700
# Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
# Parent  99c113c701ef57c5b3165f35071bbb5517372683
tests: python executable path should always be globbed

Although this is coming in under the guise of consistency, part of the
desire for this is that at least as part of the official Solaris builds,
we build with a versioned python interpreter, such as "python2.7", which
doesn't match "*python".
Augie Fackler - March 16, 2016, 5:01 p.m.
On Tue, Mar 15, 2016 at 03:54:30PM -0700, danek.duvall@oracle.com wrote:
> # HG changeset patch
> # User Danek Duvall <danek.duvall@oracle.com>
> # Date 1458082257 25200
> #      Tue Mar 15 15:50:57 2016 -0700
> # Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
> # Parent  99c113c701ef57c5b3165f35071bbb5517372683
> tests: python executable path should always be globbed
>
> Although this is coming in under the guise of consistency, part of the
> desire for this is that at least as part of the official Solaris builds,
> we build with a versioned python interpreter, such as "python2.7", which
> doesn't match "*python".
>
> diff --git a/tests/test-install.t b/tests/test-install.t
> --- a/tests/test-install.t
> +++ b/tests/test-install.t
> @@ -25,7 +25,7 @@ hg debuginstall JSON
>      "extensionserror": null,
>      "hgmodules": "*mercurial", (glob)
>      "problems": 0,
> -    "pythonexe": "*python", (glob)
> +    "pythonexe": "*", (glob)

This weirds me out just a little. Can I interest you in *py*? That
would still match (say) python, python2.7, and pypy, but would at
least fail to match ruby. Thoughts?

(I might be too paranoid here.)

>      "pythonlib": "*python*", (glob)
>      "pythonver": "*.*.*", (glob)
>      "templatedirs": "*mercurial?templates", (glob)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Danek Duvall - March 16, 2016, 5:59 p.m.
Augie Fackler wrote:

> On Tue, Mar 15, 2016 at 03:54:30PM -0700, danek.duvall@oracle.com wrote:
> > # HG changeset patch
> > # User Danek Duvall <danek.duvall@oracle.com>
> > # Date 1458082257 25200
> > #      Tue Mar 15 15:50:57 2016 -0700
> > # Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
> > # Parent  99c113c701ef57c5b3165f35071bbb5517372683
> > tests: python executable path should always be globbed
> >
> > Although this is coming in under the guise of consistency, part of the
> > desire for this is that at least as part of the official Solaris builds,
> > we build with a versioned python interpreter, such as "python2.7", which
> > doesn't match "*python".
> >
> > diff --git a/tests/test-install.t b/tests/test-install.t
> > --- a/tests/test-install.t
> > +++ b/tests/test-install.t
> > @@ -25,7 +25,7 @@ hg debuginstall JSON
> >      "extensionserror": null,
> >      "hgmodules": "*mercurial", (glob)
> >      "problems": 0,
> > -    "pythonexe": "*python", (glob)
> > +    "pythonexe": "*", (glob)
> 
> This weirds me out just a little. Can I interest you in *py*? That
> would still match (say) python, python2.7, and pypy, but would at
> least fail to match ruby. Thoughts?

Sure, that'd be fine with me, but then we probably ought to change all of
them, right?  I just went for the smallest change here.

Danek
Sean Farley - March 16, 2016, 9:12 p.m.
Augie Fackler <raf@durin42.com> writes:

> On Tue, Mar 15, 2016 at 03:54:30PM -0700, danek.duvall@oracle.com wrote:
>> # HG changeset patch
>> # User Danek Duvall <danek.duvall@oracle.com>
>> # Date 1458082257 25200
>> #      Tue Mar 15 15:50:57 2016 -0700
>> # Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
>> # Parent  99c113c701ef57c5b3165f35071bbb5517372683
>> tests: python executable path should always be globbed
>>
>> Although this is coming in under the guise of consistency, part of the
>> desire for this is that at least as part of the official Solaris builds,
>> we build with a versioned python interpreter, such as "python2.7", which
>> doesn't match "*python".
>>
>> diff --git a/tests/test-install.t b/tests/test-install.t
>> --- a/tests/test-install.t
>> +++ b/tests/test-install.t
>> @@ -25,7 +25,7 @@ hg debuginstall JSON
>>      "extensionserror": null,
>>      "hgmodules": "*mercurial", (glob)
>>      "problems": 0,
>> -    "pythonexe": "*python", (glob)
>> +    "pythonexe": "*", (glob)
>
> This weirds me out just a little. Can I interest you in *py*? That
> would still match (say) python, python2.7, and pypy, but would at
> least fail to match ruby. Thoughts?
>
> (I might be too paranoid here.)

I also was a little paranoid but I recently used a few esoteric python
compilers / interpreters (pyston and nuitka come to mind) so I'm ok with
a generic glob for now.
Augie Fackler - March 16, 2016, 11:20 p.m.
On Mar 16, 2016 5:09 PM, "Danek Duvall" <danek.duvall@oracle.com> wrote:
>
> Augie Fackler wrote:
>
> > On Tue, Mar 15, 2016 at 03:54:30PM -0700, danek.duvall@oracle.com wrote:
> > > # HG changeset patch
> > > # User Danek Duvall <danek.duvall@oracle.com>
> > > # Date 1458082257 25200
> > > #      Tue Mar 15 15:50:57 2016 -0700
> > > # Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
> > > # Parent  99c113c701ef57c5b3165f35071bbb5517372683
> > > tests: python executable path should always be globbed
> > >
> > > Although this is coming in under the guise of consistency, part of the
> > > desire for this is that at least as part of the official Solaris
builds,
> > > we build with a versioned python interpreter, such as "python2.7",
which
> > > doesn't match "*python".
> > >
> > > diff --git a/tests/test-install.t b/tests/test-install.t
> > > --- a/tests/test-install.t
> > > +++ b/tests/test-install.t
> > > @@ -25,7 +25,7 @@ hg debuginstall JSON
> > >      "extensionserror": null,
> > >      "hgmodules": "*mercurial", (glob)
> > >      "problems": 0,
> > > -    "pythonexe": "*python", (glob)
> > > +    "pythonexe": "*", (glob)
> >
> > This weirds me out just a little. Can I interest you in *py*? That
> > would still match (say) python, python2.7, and pypy, but would at
> > least fail to match ruby. Thoughts?
>
> Sure, that'd be fine with me, but then we probably ought to change all of
> them, right?  I just went for the smallest change here.

I'm convinced by Sean's message. I'll queue this once I'm able. Thanks!

>
> Danek

Patch

diff --git a/tests/test-install.t b/tests/test-install.t
--- a/tests/test-install.t
+++ b/tests/test-install.t
@@ -25,7 +25,7 @@  hg debuginstall JSON
     "extensionserror": null,
     "hgmodules": "*mercurial", (glob)
     "problems": 0,
-    "pythonexe": "*python", (glob)
+    "pythonexe": "*", (glob)
     "pythonlib": "*python*", (glob)
     "pythonver": "*.*.*", (glob)
     "templatedirs": "*mercurial?templates", (glob)