Patchwork [1,of,2] zeroconf: remove one last camelcase in identifiers

login
register
mail settings
Submitter Danek Duvall
Date March 15, 2016, 9:02 p.m.
Message ID <0bb0e0813edcb4cdda18.1458075763@smelly.us.oracle.com>
Download mbox | patch
Permalink /patch/13901/
State Superseded
Headers show

Comments

Danek Duvall - March 15, 2016, 9:02 p.m.
# HG changeset patch
# User Danek Duvall <danek.duvall@oracle.com>
# Date 1458074323 25200
#      Tue Mar 15 13:38:43 2016 -0700
# Node ID 0bb0e0813edcb4cdda18c5d950fd0df8d90b119f
# Parent  70c2f8a982766b512e9d7f41f2d93fdb92f5481f
zeroconf: remove one last camelcase in identifiers
Augie Fackler - March 16, 2016, 4:52 p.m.
On Tue, Mar 15, 2016 at 02:02:43PM -0700, danek.duvall@oracle.com wrote:
> # HG changeset patch
> # User Danek Duvall <danek.duvall@oracle.com>
> # Date 1458074323 25200
> #      Tue Mar 15 13:38:43 2016 -0700
> # Node ID 0bb0e0813edcb4cdda18c5d950fd0df8d90b119f
> # Parent  70c2f8a982766b512e9d7f41f2d93fdb92f5481f
> zeroconf: remove one last camelcase in identifiers

Already fixed by 3c90090320ad, thanks!

>
> diff --git a/hgext/zeroconf/Zeroconf.py b/hgext/zeroconf/Zeroconf.py
> --- a/hgext/zeroconf/Zeroconf.py
> +++ b/hgext/zeroconf/Zeroconf.py
> @@ -555,7 +555,7 @@ class DNSIncoming(object):
>          """Reads answers, authorities and additionals section of the packet"""
>          format = '!HHiH'
>          length = struct.calcsize(format)
> -        n = self.numanswers + self.numAuthorities + self.numadditionals
> +        n = self.numanswers + self.numauthorities + self.numadditionals
>          for i in range(0, n):
>              domain = self.readName()
>              info = struct.unpack(format,
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Danek Duvall - March 16, 2016, 6:01 p.m.
Augie Fackler wrote:

> On Tue, Mar 15, 2016 at 02:02:43PM -0700, danek.duvall@oracle.com wrote:
> > # HG changeset patch
> > # User Danek Duvall <danek.duvall@oracle.com>
> > # Date 1458074323 25200
> > #      Tue Mar 15 13:38:43 2016 -0700
> > # Node ID 0bb0e0813edcb4cdda18c5d950fd0df8d90b119f
> > # Parent  70c2f8a982766b512e9d7f41f2d93fdb92f5481f
> > zeroconf: remove one last camelcase in identifiers
> 
> Already fixed by 3c90090320ad, thanks!

Yeah, I noticed after I did the next pull from the repo.  I guess I should
be testing crew instead?  Or clowncopter?

Thanks,
Danek
Augie Fackler - March 16, 2016, 6:05 p.m.
> On Mar 16, 2016, at 14:01, Danek Duvall <danek.duvall@oracle.com> wrote:
> 
> Augie Fackler wrote:
> 
>> On Tue, Mar 15, 2016 at 02:02:43PM -0700, danek.duvall@oracle.com wrote:
>>> # HG changeset patch
>>> # User Danek Duvall <danek.duvall@oracle.com>
>>> # Date 1458074323 25200
>>> #      Tue Mar 15 13:38:43 2016 -0700
>>> # Node ID 0bb0e0813edcb4cdda18c5d950fd0df8d90b119f
>>> # Parent  70c2f8a982766b512e9d7f41f2d93fdb92f5481f
>>> zeroconf: remove one last camelcase in identifiers
>> 
>> Already fixed by 3c90090320ad, thanks!
> 
> Yeah, I noticed after I did the next pull from the repo.  I guess I should
> be testing crew instead?  Or clowncopter?

We'll be moving clowncopter to a new location soon, and I'll make a point to announce the change here when it's done.

> 
> Thanks,
> Danek

Patch

diff --git a/hgext/zeroconf/Zeroconf.py b/hgext/zeroconf/Zeroconf.py
--- a/hgext/zeroconf/Zeroconf.py
+++ b/hgext/zeroconf/Zeroconf.py
@@ -555,7 +555,7 @@  class DNSIncoming(object):
         """Reads answers, authorities and additionals section of the packet"""
         format = '!HHiH'
         length = struct.calcsize(format)
-        n = self.numanswers + self.numAuthorities + self.numadditionals
+        n = self.numanswers + self.numauthorities + self.numadditionals
         for i in range(0, n):
             domain = self.readName()
             info = struct.unpack(format,