Patchwork chgserver: remove outdated comment about setvbuf()

login
register
mail settings
Submitter Yuya Nishihara
Date March 11, 2016, 4:40 p.m.
Message ID <dbad88155d14559d94aa.1457714416@mimosa>
Download mbox | patch
Permalink /patch/13789/
State Accepted
Headers show

Comments

Yuya Nishihara - March 11, 2016, 4:40 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1456575457 -32400
#      Sat Feb 27 21:17:37 2016 +0900
# Node ID dbad88155d14559d94aaf59a21c5371e394039d1
# Parent  88738948f5d27cebe673ceb655c6161c34efda7d
chgserver: remove outdated comment about setvbuf()

I've replaced setvbuf() by fdopen() before merging chg into the core, so
this comment is wrong.

https://bitbucket.org/yuja/chg/commits/5c24e72bc447
Pierre-Yves David - March 11, 2016, 4:55 p.m.
On 03/11/2016 04:40 PM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1456575457 -32400
> #      Sat Feb 27 21:17:37 2016 +0900
> # Node ID dbad88155d14559d94aaf59a21c5371e394039d1
> # Parent  88738948f5d27cebe673ceb655c6161c34efda7d
> chgserver: remove outdated comment about setvbuf()
>
> I've replaced setvbuf() by fdopen() before merging chg into the core, so
> this comment is wrong.

Sure, pushed to the clowncopter.

Patch

diff --git a/hgext/chgserver.py b/hgext/chgserver.py
--- a/hgext/chgserver.py
+++ b/hgext/chgserver.py
@@ -627,8 +627,6 @@  class chgunixservice(commandserver.unixs
             'chgserver', 'idletimeout', self.server.idletimeout)
         self.server.startautoexitthread()
         self._createsymlink()
-        # avoid writing "listening at" message to stdout before attachio
-        # request, which calls setvbuf()
 
     def _inithashstate(self):
         self.baseaddress = self.address