Patchwork [Bug,5131] New: Zeroconf assumes ipv4, test fails with "abort: No such device" on ipv6-only host

login
register
mail settings
Submitter mercurial-bugs@selenic.com
Date March 8, 2016, 2:16 p.m.
Message ID <bug-5131-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/13680/
State Changes Requested
Headers show

Comments

mercurial-bugs@selenic.com - March 8, 2016, 2:16 p.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=5131

            Bug ID: 5131
           Summary: Zeroconf assumes ipv4, test fails with "abort: No such
                    device" on ipv6-only host
           Product: Mercurial
           Version: stable branch
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla@selenic.com
          Reporter: rm@fb.com
                CC: mercurial-devel@selenic.com

+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/extensions.py",
line 195, in closure
+      return func(*(args + a), **kw)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/hgext/zeroconf/__init__.py",
line 169, in configitems
+      repos += getzcpaths()
+    File "/tmp/hgtests.WkBr5O/install/lib/python/hgext/zeroconf/__init__.py",
line 148, in getzcpaths
+      server = Zeroconf.Zeroconf(ip)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/hgext/zeroconf/Zeroconf.py",
line 1277, in __init__
+      self.socket.setsockopt(socket.SOL_IP, socket.IP_ADD_MEMBERSHIP,
socket.inet_aton(_MDNS_ADDR) + socket.inet_aton('0.0.0.0'))
+    File "<string>", line 1, in setsockopt
+  error: [Errno 19] No such device
   abort: No such device
   [255]

This bisected to 72f2a19c5f88791e156711e4a90f241a1a8b3c0c

Patch

--- .../hg/tests/test-paths.t
+++ .../hg/tests/test-paths.t.err
@@ -100,6 +100,43 @@ 
 zeroconf wraps ui.configitems(), which shouldn't crash at least:

   $ hg paths --config extensions.zeroconf= --traceback
+  Traceback (most recent call last):
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/dispatch.py", line
191, in _runcatch
+      return _dispatch(req)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/dispatch.py", line
926, in _dispatch
+      cmdpats, cmdoptions)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/dispatch.py", line
682, in runcommand
+      ret = _runcommand(ui, options, cmd, d)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/extensions.py",
line 195, in closure
+      return func(*(args + a), **kw)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/hgext/zeroconf/__init__.py",
line 190, in cleanupafterdispatch
+      return orig(ui, options, cmd, cmdfunc)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/dispatch.py", line
1057, in _runcommand
+      return checkargs()
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/dispatch.py", line
1017, in checkargs
+      return cmdfunc()
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/dispatch.py", line
923, in <lambda>
+      d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/util.py", line 992,
in check
+      return func(*args, **kwargs)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/commands.py", line
5422, in paths
+      pathitems = sorted(ui.paths.iteritems())
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/util.py", line 724,
in __get__
+      result = self.func(obj)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/ui.py", line 617,
in paths
+      return paths(self)
+    File "/tmp/hgtests.WkBr5O/install/lib/python/mercurial/ui.py", line 1097,
in __init__
+      for name, loc in ui.configitems('paths', ignoresub=True):