Patchwork [13,of,24] debugdiscovery: report heads in sorted

login
register
mail settings
Submitter Mads Kiilerich
Date Dec. 16, 2012, 10:34 p.m.
Message ID <2449e26fec892aa8ab33.1355697248@localhost6.localdomain6>
Download mbox | patch
Permalink /patch/136/
State Superseded
Headers show

Comments

Mads Kiilerich - Dec. 16, 2012, 10:34 p.m.
# HG changeset patch
# User Mads Kiilerich <mads at kiilerich.com>
# Date 1355276294 -3600
# Node ID 2449e26fec892aa8ab334db4f5424011e4081f91
# Parent  50e9cac5cdf058c64e4190212be9d92a16b5a76f
debugdiscovery: report heads in sorted
Bryan O'Sullivan - Dec. 17, 2012, 9 p.m.
On Sun, Dec 16, 2012 at 2:34 PM, Mads Kiilerich <mads at kiilerich.com> wrote:

> debugdiscovery: report heads in sorted
>

Looks good, but shouldn't that be "in sorted order"?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121217/830d2988/attachment.html>

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -1826,8 +1826,8 @@ 
                                                                 force=True)
             common = set(common)
             if not opts.get('nonheads'):
-                ui.write(("unpruned common: %s\n") % " ".join([short(n)
-                                                            for n in common]))
+                ui.write(("unpruned common: %s\n") %
+                         " ".join(sorted(short(n) for n in common)))
                 dag = dagutil.revlogdag(repo.changelog)
                 all = dag.ancestorset(dag.internalizeall(common))
                 common = dag.externalizeall(dag.headsetofconnecteds(all))
@@ -1836,7 +1836,8 @@ 
         common = set(common)
         rheads = set(hds)
         lheads = set(repo.heads())
-        ui.write(("common heads: %s\n") % " ".join([short(n) for n in common]))
+        ui.write(("common heads: %s\n") %
+                 " ".join(sorted(short(n) for n in common)))
         if lheads <= common:
             ui.write(("local is subset\n"))
         elif rheads <= common:
@@ -2133,7 +2134,8 @@ 
                 ui.write(' ')
                 ui.write(hex(repl))
             ui.write(' %X ' % m._data[2])
-            ui.write(m.metadata())
+            ui.write('{%s}' % (', '.join('%r: %r' % t for t in
+                                         sorted(m.metadata().items()))))
             ui.write('\n')
 
 @command('debugpushkey', [], _('REPO NAMESPACE [KEY OLD NEW]'))
diff --git a/tests/test-setdiscovery.t b/tests/test-setdiscovery.t
--- a/tests/test-setdiscovery.t
+++ b/tests/test-setdiscovery.t
@@ -36,8 +36,8 @@ 
   % -- a -> b tree
   comparing with b
   searching for changes
-  unpruned common: b5714e113bc0 66f7d451a68b 01241442b3c2
-  common heads: b5714e113bc0 01241442b3c2
+  unpruned common: 01241442b3c2 66f7d451a68b b5714e113bc0
+  common heads: 01241442b3c2 b5714e113bc0
   local is subset
   
   % -- a -> b set
@@ -45,14 +45,14 @@ 
   query 1; heads
   searching for changes
   all local heads known remotely
-  common heads: b5714e113bc0 01241442b3c2
+  common heads: 01241442b3c2 b5714e113bc0
   local is subset
   
   % -- b -> a tree
   comparing with a
   searching for changes
-  unpruned common: b5714e113bc0 01241442b3c2
-  common heads: b5714e113bc0 01241442b3c2
+  unpruned common: 01241442b3c2 b5714e113bc0
+  common heads: 01241442b3c2 b5714e113bc0
   remote is subset
   
   % -- b -> a set
@@ -60,7 +60,7 @@ 
   query 1; heads
   searching for changes
   all remote heads known locally
-  common heads: b5714e113bc0 01241442b3c2
+  common heads: 01241442b3c2 b5714e113bc0
   remote is subset
 
 
@@ -89,7 +89,7 @@ 
   % -- b -> a tree
   comparing with a
   searching for changes
-  unpruned common: bebd167eb94d 66f7d451a68b
+  unpruned common: 66f7d451a68b bebd167eb94d
   common heads: bebd167eb94d
   
   % -- b -> a set
@@ -128,7 +128,7 @@ 
   % -- b -> a tree
   comparing with a
   searching for changes
-  unpruned common: 66f7d451a68b 2dc09a01254d
+  unpruned common: 2dc09a01254d 66f7d451a68b
   common heads: 2dc09a01254d
   
   % -- b -> a set