Patchwork [8,of,8] pager: use absolute_import

login
register
mail settings
Submitter timeless@mozdev.org
Date March 2, 2016, 9:55 p.m.
Message ID <1cdfa3780bd5bca83afb.1456955753@waste.org>
Download mbox | patch
Permalink /patch/13571/
State Accepted
Headers show

Comments

timeless@mozdev.org - March 2, 2016, 9:55 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1456955146 0
#      Wed Mar 02 21:45:46 2016 +0000
# Node ID 1cdfa3780bd5bca83afbea7bbc398327f053c08b
# Parent  81dbf397b8df734d12247c0454d3f9b84cfe0967
pager: use absolute_import
Augie Fackler - March 8, 2016, 4:19 a.m.
On Wed, Mar 02, 2016 at 03:55:53PM -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1456955146 0
> #      Wed Mar 02 21:45:46 2016 +0000
> # Node ID 1cdfa3780bd5bca83afbea7bbc398327f053c08b
> # Parent  81dbf397b8df734d12247c0454d3f9b84cfe0967
> pager: use absolute_import
>

patches 1-6 are queued, but 7 and 8 need a resend. Thanks!

> diff --git a/hgext/pager.py b/hgext/pager.py
> --- a/hgext/pager.py
> +++ b/hgext/pager.py
> @@ -58,9 +58,21 @@
>    will also work).
>
>  '''
> +from __future__ import absolute_import
>
> -import atexit, sys, os, signal, subprocess
> -from mercurial import commands, dispatch, util, extensions, cmdutil
> +import atexit
> +import os
> +import signal
> +import subprocess
> +import sys
> +
> +from mercurial import (
> +    cmdutil,
> +    commands,
> +    dispatch,
> +    extensions,
> +    util,
> +)
>  from mercurial.i18n import _
>
>  # Note for extension authors: ONLY specify testedwith = 'internal' for
> diff --git a/tests/test-check-py3-compat.t b/tests/test-check-py3-compat.t
> --- a/tests/test-check-py3-compat.t
> +++ b/tests/test-check-py3-compat.t
> @@ -73,7 +73,6 @@
>    hgext/largefiles/wirestore.py not using absolute_import
>    hgext/mq.py not using absolute_import
>    hgext/notify.py not using absolute_import
> -  hgext/pager.py not using absolute_import
>    hgext/rebase.py not using absolute_import
>    hgext/share.py not using absolute_import
>    hgext/transplant.py not using absolute_import
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/hgext/pager.py b/hgext/pager.py
--- a/hgext/pager.py
+++ b/hgext/pager.py
@@ -58,9 +58,21 @@ 
   will also work).
 
 '''
+from __future__ import absolute_import
 
-import atexit, sys, os, signal, subprocess
-from mercurial import commands, dispatch, util, extensions, cmdutil
+import atexit
+import os
+import signal
+import subprocess
+import sys
+
+from mercurial import (
+    cmdutil,
+    commands,
+    dispatch,
+    extensions,
+    util,
+)
 from mercurial.i18n import _
 
 # Note for extension authors: ONLY specify testedwith = 'internal' for
diff --git a/tests/test-check-py3-compat.t b/tests/test-check-py3-compat.t
--- a/tests/test-check-py3-compat.t
+++ b/tests/test-check-py3-compat.t
@@ -73,7 +73,6 @@ 
   hgext/largefiles/wirestore.py not using absolute_import
   hgext/mq.py not using absolute_import
   hgext/notify.py not using absolute_import
-  hgext/pager.py not using absolute_import
   hgext/rebase.py not using absolute_import
   hgext/share.py not using absolute_import
   hgext/transplant.py not using absolute_import