| Submitter | Jun Wu |
|---|---|
| Date | Feb. 29, 2016, 2:20 p.m. |
| Message ID | <56D453C2.1070000@fb.com> |
| Download | mbox | patch |
| Permalink | /patch/13468/ |
| State | Not Applicable |
| Headers | show |
Comments
On Mon, 29 Feb 2016 14:20:50 +0000, Jun Wu wrote: > I have been getting "ERROR: test-check-commit.t output changed" for a > while and traced back to this. > > --- test-hook.t > +++ test-hook.t.err > @@ -536,7 +536,7 @@ > exception from first failed import attempt: > Traceback (most recent call last): > > - ^ > + ^ Perhaps it depends on Python versions where the syntax error is detected. Do we need these lines in tests?
On 29 February 2016 at 16:19, Yuya Nishihara <yuya@tcha.org> wrote:
> Perhaps it depends on Python versions where the syntax error is detected.
Looks like it. I get the test failure when using Python 2.6, not with
Python 2.7.
And that's surprising, because a plain test file with `(foo` on a line
gives the exact same syntax error output in 2.6 or 2.7. So this is may
be an issue with the `traceback` module in 2.6.
Perhaps a different syntax error can be devised that doesn't exhibit this issue.
On 03/04/2016 04:04 PM, Martijn Pieters wrote: > On 29 February 2016 at 16:19, Yuya Nishihara <yuya@tcha.org> wrote: >> Perhaps it depends on Python versions where the syntax error is detected. > > Looks like it. I get the test failure when using Python 2.6, not with > Python 2.7. > > And that's surprising, because a plain test file with `(foo` on a line > gives the exact same syntax error output in 2.6 or 2.7. So this is may > be an issue with the `traceback` module in 2.6. > > Perhaps a different syntax error can be devised that doesn't exhibit this issue. We should probably just (glob) it.
On 3/8/16 04:13, Pierre-Yves David wrote: > > > On 03/04/2016 04:04 PM, Martijn Pieters wrote: >> On 29 February 2016 at 16:19, Yuya Nishihara <yuya@tcha.org> wrote: >>> Perhaps it depends on Python versions where the syntax error is >>> detected. >> >> Looks like it. I get the test failure when using Python 2.6, not with >> Python 2.7. >> >> And that's surprising, because a plain test file with `(foo` on a line >> gives the exact same syntax error output in 2.6 or 2.7. So this is may >> be an issue with the `traceback` module in 2.6. >> >> Perhaps a different syntax error can be devised that doesn't exhibit >> this issue. > > We should probably just (glob) it. > Just sent a patch filtering this out.
Patch
--- test-hook.t +++ test-hook.t.err @@ -536,7 +536,7 @@ exception from first failed import attempt: Traceback (most recent call last): - ^ + ^ SyntaxError: invalid syntax exception from second failed import attempt: Traceback (most recent call last):