Submitter | timeless |
---|---|
Date | Jan. 22, 2016, 8:08 p.m. |
Message ID | <CAAKMeYi2ZL064HZgeVX8_dCap52OBG1FJsZthGV2WRm3r3b4oA@mail.gmail.com> |
Download | mbox | patch |
Permalink | /patch/12870/ |
State | Accepted |
Commit | a6833e464b070c2f51edff8d6e55be79f5d9db22 |
Headers | show |
Comments
On 01/22/2016 12:08 PM, timeless wrote: > Pierre-Yves David wrote: >> How much of your issue is related to "bryan patch failure to fix the race >> introduced by Laurent" and how much is it of "run-tests.py interruption have >> been borked since forever"? > > all of it. > >> I've personnally never have been confortable with ctrl^C run-tests.py in years. > > I've always been moderately annoyed by it, but I do get a prompt if I > don't try to fix the errors. If I or anyone else (i.e. bos) tries to > fix the channel stuff, the result tends to be no prompt because > something swallows something and the script doesn't terminate, which > is definitely worse than some ugly exceptions. What's the way forward here, is the Bryan approach adjustable to provide good result? Do you have an alternative in mind? should we backout Laurent's patch?
Patch
--- /home/timeless/hg/crew/tests/test-check-execute.t +++ /home/timeless/hg/crew/tests/test-check-execute.t.err @@ -5,6 +5,7 @@ look for python scripts without the execute bit $ hg files 'set:**.py and not exec() and grep(r"^#!.*?python")' + obsolete feature not enabled but 97599 markers found! [1] look for python scripts with execute bit but not shebang