Patchwork [2,of,8] paths: reorder else clause for readability of subsequent patches

login
register
mail settings
Submitter Yuya Nishihara
Date Jan. 12, 2016, 10:34 p.m.
Message ID <64ee5866e1076b864ca9.1452638040@waste.org>
Download mbox | patch
Permalink /patch/12712/
State Accepted
Commit 64ee5866e1076b864ca91b215012bb2a438b99b7
Headers show

Comments

Yuya Nishihara - Jan. 12, 2016, 10:34 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1450011357 -32400
#      Sun Dec 13 21:55:57 2015 +0900
# Node ID 64ee5866e1076b864ca91b215012bb2a438b99b7
# Parent  c36fa631cb6ebfc1549127ab7f1d5cd542908283
paths: reorder else clause for readability of subsequent patches

This prepares for porting to the formatter API. Future patches will use a
single loop to handle both search=None|pattern cases because formatter output
should be the same. "pathitems" will be switched instead.

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -5407,14 +5407,15 @@ 
             ui.warn(_("not found!\n"))
         return 1
     else:
-        for name, path in sorted(ui.paths.iteritems()):
-            if ui.quiet:
-                ui.write("%s\n" % name)
-            else:
-                ui.write("%s = %s\n" % (name,
-                                        util.hidepassword(path.rawloc)))
-                for subopt, value in sorted(path.suboptions.items()):
-                    ui.write('%s:%s = %s\n' % (name, subopt, value))
+        pathitems = sorted(ui.paths.iteritems())
+
+    for name, path in pathitems:
+        if ui.quiet:
+            ui.write("%s\n" % name)
+        else:
+            ui.write("%s = %s\n" % (name, util.hidepassword(path.rawloc)))
+            for subopt, value in sorted(path.suboptions.items()):
+                ui.write('%s:%s = %s\n' % (name, subopt, value))
 
 @command('phase',
     [('p', 'public', False, _('set changeset phase to public')),