Patchwork [2,of,2] tests: guard mtime access

login
register
mail settings
Submitter timeless@mozdev.org
Date Jan. 12, 2016, 5:54 a.m.
Message ID <8f4ae485c92be694d385.1452578070@waste.org>
Download mbox | patch
Permalink /patch/12679/
State Changes Requested
Headers show

Comments

timeless@mozdev.org - Jan. 12, 2016, 5:54 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1452576602 18000
#      Tue Jan 12 00:30:02 2016 -0500
# Node ID 8f4ae485c92be694d385a96b95e527a8ba1a855c
# Parent  c561f00fa2ffc7b2967ad8231b052c74084df367
tests: guard mtime access

FAT on Darwin does not restore mtime
Augie Fackler - Jan. 12, 2016, 3:24 p.m.
On Mon, Jan 11, 2016 at 11:54:30PM -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1452576602 18000
> #      Tue Jan 12 00:30:02 2016 -0500
> # Node ID 8f4ae485c92be694d385a96b95e527a8ba1a855c
> # Parent  c561f00fa2ffc7b2967ad8231b052c74084df367
> tests: guard mtime access
>
> FAT on Darwin does not restore mtime

Huh? Works on my OS X (10.11). I can touch files on a FAT disk image
to arbitrary times and it works fine.

>
> diff --git a/tests/test-archive.t b/tests/test-archive.t
> --- a/tests/test-archive.t
> +++ b/tests/test-archive.t
> @@ -351,8 +351,10 @@
>
>    $ hg -R repo archive --prefix tar-extracted archive.tar
>    $ (TZ=UTC-3; export TZ; tar xf archive.tar)
> +#if unix-permissions
>    $ python show_mtime.py tar-extracted/a
>    456789012
> +#endif
>
>    $ hg -R repo archive --prefix zip-extracted archive.zip
>    $ (TZ=UTC-3; export TZ; unzip -q archive.zip)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/tests/test-archive.t b/tests/test-archive.t
--- a/tests/test-archive.t
+++ b/tests/test-archive.t
@@ -351,8 +351,10 @@ 
 
   $ hg -R repo archive --prefix tar-extracted archive.tar
   $ (TZ=UTC-3; export TZ; tar xf archive.tar)
+#if unix-permissions
   $ python show_mtime.py tar-extracted/a
   456789012
+#endif
 
   $ hg -R repo archive --prefix zip-extracted archive.zip
   $ (TZ=UTC-3; export TZ; unzip -q archive.zip)