Patchwork tests: run check-commit on secret changes too

login
register
mail settings
Submitter Matt Mackall
Date Jan. 11, 2016, 5:48 p.m.
Message ID <4647cfbfde40fb18534c.1452534484@ruin.waste.org>
Download mbox | patch
Permalink /patch/12659/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

Matt Mackall - Jan. 11, 2016, 5:48 p.m.
# HG changeset patch
# User Matt Mackall <mpm@selenic.com>
# Date 1452533728 21600
#      Mon Jan 11 11:35:28 2016 -0600
# Node ID 4647cfbfde40fb18534cc1df4859a16d231bbdd9
# Parent  5b216b4a17ab760048e19d9d795810a49c7f7c4a
tests: run check-commit on secret changes too
Yuya Nishihara - Jan. 14, 2016, 3:10 p.m.
On Mon, 11 Jan 2016 11:48:04 -0600, Matt Mackall wrote:
> # HG changeset patch
> # User Matt Mackall <mpm@selenic.com>
> # Date 1452533728 21600
> #      Mon Jan 11 11:35:28 2016 -0600
> # Node ID 4647cfbfde40fb18534cc1df4859a16d231bbdd9
> # Parent  5b216b4a17ab760048e19d9d795810a49c7f7c4a
> tests: run check-commit on secret changes too
> 
> diff -r 5b216b4a17ab -r 4647cfbfde40 tests/test-check-commit.t
> --- a/tests/test-check-commit.t	Fri Jan 08 12:07:15 2016 -0600
> +++ b/tests/test-check-commit.t	Mon Jan 11 11:35:28 2016 -0600
> @@ -11,7 +11,7 @@
>  
>    $ cd $TESTDIR/..
>  
> -  $ for node in `hg log --rev 'draft() and ::.' --template '{node|short}\n'`; do
> +  $ for node in `hg log --rev 'not public() and ::.' --template '{node|short}\n'`; do

Seems fine as secret changes can be sent as patches. Pushed to the clowncopter,
thanks.

Patch

diff -r 5b216b4a17ab -r 4647cfbfde40 tests/test-check-commit.t
--- a/tests/test-check-commit.t	Fri Jan 08 12:07:15 2016 -0600
+++ b/tests/test-check-commit.t	Mon Jan 11 11:35:28 2016 -0600
@@ -11,7 +11,7 @@ 
 
   $ cd $TESTDIR/..
 
-  $ for node in `hg log --rev 'draft() and ::.' --template '{node|short}\n'`; do
+  $ for node in `hg log --rev 'not public() and ::.' --template '{node|short}\n'`; do
   >    hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out
   >    if [ $? -ne 0 ]; then
   >        echo "Revision $node does not comply to rules"