Patchwork [stable] installer: add windows application version number to inno installer script

login
register
mail settings
Submitter Urs Rau
Date Jan. 7, 2016, 1:24 p.m.
Message ID <c904bd0798f19a085988.1452173069@uk-ubuntu1.uk.om.org>
Download mbox | patch
Permalink /patch/12587/
State Accepted
Headers show

Comments

Urs Rau - Jan. 7, 2016, 1:24 p.m.
# HG changeset patch
# User Urs Rau <urs.rau@gmail.com>
# Date 1452170966 0
#      Thu Jan 07 12:49:26 2016 +0000
# Branch stable
# Node ID c904bd0798f19a085988462b323b98e7d57e485e
# Parent  7c598947fbbd78b26989326c61345c6e46855bdc
installer: add windows application version number to inno installer script

this addition to the inno installer script means that the windows uninstaller registry key “DisplayVersion" is set to the application version number and will show in Add/Remove Programs
Urs Rau - Jan. 7, 2016, 3:50 p.m.
Hi folks,

> On 7 Jan 2016, at 13:24, Urs Rau <urs.rau@gmail.com> wrote:
> 
> # HG changeset patch
> # User Urs Rau <urs.rau@gmail.com>
> # Date 1452170966 0
> #      Thu Jan 07 12:49:26 2016 +0000
> # Branch stable
> # Node ID c904bd0798f19a085988462b323b98e7d57e485e
> # Parent  7c598947fbbd78b26989326c61345c6e46855bdc
> installer: add windows application version number to inno installer script



I have “hg email” submittted a very very simple patch (1 line added to mercurial.iss inno installer setup file) that would really help configuration management tools like saltstack or chocolatey, or chef or puppet etc. to automatically and silently install and manage mercurial deployments.

What other steps can (or should) I take to try to get the next mercurial installer to actually have the “DisplayVersion" set in the windows registry, so that Add/Remove Programs and automation tools can read the installed version number from the registry uninstall key?

Looking for guidance, I m not really a mercurial developer, but somebody interested in the next released version of mercurial into installer to actually set the right key in the windows uninstaller registry key.

Thanks.

Regards

—  
Urs Rau
Pierre-Yves David - Jan. 8, 2016, 1:11 p.m.
As commented on the other incarnation of this patch, This looks fine, 
but I would like someone with windows knowledge to have a look at his.

On 01/07/2016 01:24 PM, Urs Rau wrote:
> # HG changeset patch
> # User Urs Rau <urs.rau@gmail.com>
> # Date 1452170966 0
> #      Thu Jan 07 12:49:26 2016 +0000
> # Branch stable
> # Node ID c904bd0798f19a085988462b323b98e7d57e485e
> # Parent  7c598947fbbd78b26989326c61345c6e46855bdc
> installer: add windows application version number to inno installer script
>
> this addition to the inno installer script means that the windows uninstaller registry key “DisplayVersion" is set to the application version number and will show in Add/Remove Programs
>
> diff -r 7c598947fbbd -r c904bd0798f1 contrib/win32/mercurial.iss
> --- a/contrib/win32/mercurial.iss	Sat Jan 02 02:04:32 2016 +0100
> +++ b/contrib/win32/mercurial.iss	Thu Jan 07 12:49:26 2016 +0000
> @@ -23,6 +23,7 @@
>   [Setup]
>   AppCopyright=Copyright 2005-2015 Matt Mackall and others
>   AppName=Mercurial
> +AppVersion={#VERSION}
>   #if ARCH == "x64"
>   AppVerName=Mercurial {#VERSION} (64-bit)
>   OutputBaseFilename=Mercurial-{#VERSION}-x64
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel
>
Pascal Quantin - Jan. 8, 2016, 7:34 p.m.
2016-01-08 14:11 GMT+01:00 Pierre-Yves David <pierre-yves.david@ens-lyon.org
>:

> As commented on the other incarnation of this patch, This looks fine, but
> I would like someone with windows knowledge to have a look at his.


LGTM.

Regards,
Pascal.


>
>
> On 01/07/2016 01:24 PM, Urs Rau wrote:
>
>> # HG changeset patch
>> # User Urs Rau <urs.rau@gmail.com>
>> # Date 1452170966 0
>> #      Thu Jan 07 12:49:26 2016 +0000
>> # Branch stable
>> # Node ID c904bd0798f19a085988462b323b98e7d57e485e
>> # Parent  7c598947fbbd78b26989326c61345c6e46855bdc
>> installer: add windows application version number to inno installer script
>>
>> this addition to the inno installer script means that the windows
>> uninstaller registry key “DisplayVersion" is set to the application version
>> number and will show in Add/Remove Programs
>>
>> diff -r 7c598947fbbd -r c904bd0798f1 contrib/win32/mercurial.iss
>> --- a/contrib/win32/mercurial.iss       Sat Jan 02 02:04:32 2016 +0100
>> +++ b/contrib/win32/mercurial.iss       Thu Jan 07 12:49:26 2016 +0000
>> @@ -23,6 +23,7 @@
>>   [Setup]
>>   AppCopyright=Copyright 2005-2015 Matt Mackall and others
>>   AppName=Mercurial
>> +AppVersion={#VERSION}
>>   #if ARCH == "x64"
>>   AppVerName=Mercurial {#VERSION} (64-bit)
>>   OutputBaseFilename=Mercurial-{#VERSION}-x64
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel@selenic.com
>> https://selenic.com/mailman/listinfo/mercurial-devel
>>
>>
> --
> Pierre-Yves David
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel
>
Yuya Nishihara - Jan. 9, 2016, 3:11 a.m.
On Thu, 07 Jan 2016 13:24:29 +0000, Urs Rau wrote:
> # HG changeset patch
> # User Urs Rau <urs.rau@gmail.com>
> # Date 1452170966 0
> #      Thu Jan 07 12:49:26 2016 +0000
> # Branch stable
> # Node ID c904bd0798f19a085988462b323b98e7d57e485e
> # Parent  7c598947fbbd78b26989326c61345c6e46855bdc
> installer: add windows application version number to inno installer script

Pushed to the clowncopter as per Pascal Quantin's review. Thanks!

Patch

diff -r 7c598947fbbd -r c904bd0798f1 contrib/win32/mercurial.iss
--- a/contrib/win32/mercurial.iss	Sat Jan 02 02:04:32 2016 +0100
+++ b/contrib/win32/mercurial.iss	Thu Jan 07 12:49:26 2016 +0000
@@ -23,6 +23,7 @@ 
 [Setup]
 AppCopyright=Copyright 2005-2015 Matt Mackall and others
 AppName=Mercurial
+AppVersion={#VERSION}
 #if ARCH == "x64"
 AppVerName=Mercurial {#VERSION} (64-bit)
 OutputBaseFilename=Mercurial-{#VERSION}-x64