Patchwork [1,of,4] test-check-execute.t: ignore obsolete warning

login
register
mail settings
Submitter timeless@mozdev.org
Date Jan. 6, 2016, 5:12 a.m.
Message ID <3cfba7249e5d046e380b.1452057154@waste.org>
Download mbox | patch
Permalink /patch/12557/
State Rejected
Headers show

Comments

timeless@mozdev.org - Jan. 6, 2016, 5:12 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1452053896 0
#      Wed Jan 06 04:18:16 2016 +0000
# Node ID 3cfba7249e5d046e380b3b386f6f05c575a00c5d
# Parent  b8405d739149cdd6d8d9bd5e3dd2ad8487b1f09a
test-check-execute.t: ignore obsolete warning
Augie Fackler - Jan. 7, 2016, 12:49 a.m.
On Tue, Jan 05, 2016 at 11:12:34PM -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1452053896 0
> #      Wed Jan 06 04:18:16 2016 +0000
> # Node ID 3cfba7249e5d046e380b3b386f6f05c575a00c5d
> # Parent  b8405d739149cdd6d8d9bd5e3dd2ad8487b1f09a
> test-check-execute.t: ignore obsolete warning

I assume this is ignoring the obsolete warning from hg? Maybe mention
that in a longer commit message body (I had to figure out what you
meant.)

>
> diff --git a/tests/test-check-execute.t b/tests/test-check-execute.t
> --- a/tests/test-check-execute.t
> +++ b/tests/test-check-execute.t
> @@ -4,20 +4,20 @@
>
>  look for python scripts without the execute bit
>
> -  $ hg files 'set:**.py and not exec() and grep(r"^#!.*?python")'
> -  [1]
> +  $ hg files 'set:**.py and not exec() and grep(r"^#!.*?python")' \
> +  > 2> /dev/null || true
>
>  look for python scripts with execute bit but not shebang
>
> -  $ hg files 'set:**.py and exec() and not grep(r"^#!.*?python")'
> -  [1]
> +  $ hg files 'set:**.py and exec() and not grep(r"^#!.*?python")' \
> +  > 2> /dev/null || true
>
>  look for shell scripts with execute bit but not shebang
>
> -  $ hg files 'set:**.sh and exec() and not grep(r"^#!.*(ba)?sh")'
> -  [1]
> +  $ hg files 'set:**.sh and exec() and not grep(r"^#!.*(ba)?sh")' \
> +  > 2> /dev/null || true
>
>  look for non scripts with no shebang
>
> -  $ hg files 'set:exec() and not **.sh and not **.py and not grep(r"^#!")'
> -  [1]
> +  $ hg files 'set:exec() and not **.sh and not **.py and not grep(r"^#!")' \
> +  > 2> /dev/null || true
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel
Sean Farley - Jan. 7, 2016, 12:56 a.m.
Augie Fackler <raf@durin42.com> writes:

> On Tue, Jan 05, 2016 at 11:12:34PM -0600, timeless wrote:
>> # HG changeset patch
>> # User timeless <timeless@mozdev.org>
>> # Date 1452053896 0
>> #      Wed Jan 06 04:18:16 2016 +0000
>> # Node ID 3cfba7249e5d046e380b3b386f6f05c575a00c5d
>> # Parent  b8405d739149cdd6d8d9bd5e3dd2ad8487b1f09a
>> test-check-execute.t: ignore obsolete warning
>
> I assume this is ignoring the obsolete warning from hg? Maybe mention
> that in a longer commit message body (I had to figure out what you
> meant.)

I couldn't get this to trigger so I don't know how timeless is seeing
this warning. To me, that would indicate this patch is covering up
something more suspicious, possibly.

Patch

diff --git a/tests/test-check-execute.t b/tests/test-check-execute.t
--- a/tests/test-check-execute.t
+++ b/tests/test-check-execute.t
@@ -4,20 +4,20 @@ 
 
 look for python scripts without the execute bit
 
-  $ hg files 'set:**.py and not exec() and grep(r"^#!.*?python")'
-  [1]
+  $ hg files 'set:**.py and not exec() and grep(r"^#!.*?python")' \
+  > 2> /dev/null || true
 
 look for python scripts with execute bit but not shebang
 
-  $ hg files 'set:**.py and exec() and not grep(r"^#!.*?python")'
-  [1]
+  $ hg files 'set:**.py and exec() and not grep(r"^#!.*?python")' \
+  > 2> /dev/null || true
 
 look for shell scripts with execute bit but not shebang
 
-  $ hg files 'set:**.sh and exec() and not grep(r"^#!.*(ba)?sh")'
-  [1]
+  $ hg files 'set:**.sh and exec() and not grep(r"^#!.*(ba)?sh")' \
+  > 2> /dev/null || true
 
 look for non scripts with no shebang
 
-  $ hg files 'set:exec() and not **.sh and not **.py and not grep(r"^#!")'
-  [1]
+  $ hg files 'set:exec() and not **.sh and not **.py and not grep(r"^#!")' \
+  > 2> /dev/null || true