Patchwork [1,of,4] error: refactor OutOfBandError to inherrit from HintException

login
register
mail settings
Submitter timeless@mozdev.org
Date Dec. 23, 2015, 5:58 p.m.
Message ID <96379fd1a2478dc47028.1450893530@waste.org>
Download mbox | patch
Permalink /patch/12301/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

timeless@mozdev.org - Dec. 23, 2015, 5:58 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1450892304 0
#      Wed Dec 23 17:38:24 2015 +0000
# Node ID 96379fd1a2478dc4702844e5518396fee28d7414
# Parent  fe376159a58d9b3d748b669ac011b0eed0346fea
error: refactor OutOfBandError to inherrit from HintException
Yuya Nishihara - Dec. 26, 2015, 12:53 p.m.
On Wed, 23 Dec 2015 11:58:50 -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1450892304 0
> #      Wed Dec 23 17:38:24 2015 +0000
> # Node ID 96379fd1a2478dc4702844e5518396fee28d7414
> # Parent  fe376159a58d9b3d748b669ac011b0eed0346fea
> error: refactor OutOfBandError to inherrit from HintException

Looks good, pushed the series to the clowncopter, thanks.

Patch

diff --git a/mercurial/error.py b/mercurial/error.py
--- a/mercurial/error.py
+++ b/mercurial/error.py
@@ -78,13 +78,9 @@ 
         from .i18n import _
         Abort.__init__(self, _('response expected'))
 
-class OutOfBandError(Exception):
+class OutOfBandError(HintException):
     """Exception raised when a remote repo reports failure"""
 
-    def __init__(self, *args, **kw):
-        Exception.__init__(self, *args)
-        self.hint = kw.get('hint')
-
 class ParseError(Exception):
     """Raised when parsing config files and {rev,file}sets (msg[, pos])"""