Patchwork revlog: fix indent (issue5019)

login
register
mail settings
Submitter André Sintzoff
Date Dec. 19, 2015, 9:23 a.m.
Message ID <005f61f35d13ed295f8f.1450517039@zibeline.local>
Download mbox | patch
Permalink /patch/12183/
State Superseded
Headers show

Comments

André Sintzoff - Dec. 19, 2015, 9:23 a.m.
# HG changeset patch
# User André Sintzoff <andre.sintzoff@gmail.com>
# Date 1450516999 -3600
#      Sat Dec 19 10:23:19 2015 +0100
# Branch stable
# Node ID 005f61f35d13ed295f8f369c75cf74a9c6bee287
# Parent  e240e914d2261788c3ba700401659c11ed820fe3
revlog: fix indent (issue5019)
André Sintzoff - Dec. 19, 2015, 9:32 a.m.
2015-12-19 10:23 GMT+01:00 André Sintzoff <andre.sintzoff@gmail.com>:
> # HG changeset patch
> # User André Sintzoff <andre.sintzoff@gmail.com>
> # Date 1450516999 -3600
> #      Sat Dec 19 10:23:19 2015 +0100
> # Branch stable
> # Node ID 005f61f35d13ed295f8f369c75cf74a9c6bee287
> # Parent  e240e914d2261788c3ba700401659c11ed820fe3
> revlog: fix indent (issue5019)
>
> diff -r e240e914d226 -r 005f61f35d13 mercurial/revlog.py
> --- a/mercurial/revlog.py       Thu Dec 17 17:16:02 2015 -0800
> +++ b/mercurial/revlog.py       Sat Dec 19 10:23:19 2015 +0100
> @@ -1438,7 +1438,7 @@
>          # We work around this issue by inserting a seek() before writing.
>          # Note: This is likely not necessary on Python 3.
>          ifh.seek(0, os.SEEK_END)
> -        if dfh:
> +        if dfh:
>              dfh.seek(0, os.SEEK_END)
>
>          curr = len(self) - 1

BTW, I'm little bit surprised that a tab was included in a Python file.

Is there no contrib/check-code.py performed on all the modified files
before pushing to an "official" repository?
Yuya Nishihara - Dec. 19, 2015, 11:06 a.m.
On Sat, 19 Dec 2015 10:32:30 +0100, André Sintzoff wrote:
> 2015-12-19 10:23 GMT+01:00 André Sintzoff <andre.sintzoff@gmail.com>:
> > # HG changeset patch
> > # User André Sintzoff <andre.sintzoff@gmail.com>
> > # Date 1450516999 -3600
> > #      Sat Dec 19 10:23:19 2015 +0100
> > # Branch stable
> > # Node ID 005f61f35d13ed295f8f369c75cf74a9c6bee287
> > # Parent  e240e914d2261788c3ba700401659c11ed820fe3
> > revlog: fix indent (issue5019)
> >
> > diff -r e240e914d226 -r 005f61f35d13 mercurial/revlog.py
> > --- a/mercurial/revlog.py       Thu Dec 17 17:16:02 2015 -0800
> > +++ b/mercurial/revlog.py       Sat Dec 19 10:23:19 2015 +0100
> > @@ -1438,7 +1438,7 @@
> >          # We work around this issue by inserting a seek() before writing.
> >          # Note: This is likely not necessary on Python 3.
> >          ifh.seek(0, os.SEEK_END)
> > -        if dfh:
> > +        if dfh:
> >              dfh.seek(0, os.SEEK_END)

Already fixed in the clowncopter.

> BTW, I'm little bit surprised that a tab was included in a Python file.
> 
> Is there no contrib/check-code.py performed on all the modified files
> before pushing to an "official" repository?

Perhaps the tests were run after merging it to the default branch.

Patch

diff -r e240e914d226 -r 005f61f35d13 mercurial/revlog.py
--- a/mercurial/revlog.py	Thu Dec 17 17:16:02 2015 -0800
+++ b/mercurial/revlog.py	Sat Dec 19 10:23:19 2015 +0100
@@ -1438,7 +1438,7 @@ 
         # We work around this issue by inserting a seek() before writing.
         # Note: This is likely not necessary on Python 3.
         ifh.seek(0, os.SEEK_END)
-	 if dfh:
+        if dfh:
             dfh.seek(0, os.SEEK_END)
 
         curr = len(self) - 1