Patchwork help: add missed last new line to "internals" topic

login
register
mail settings
Submitter Yuya Nishihara
Date Dec. 17, 2015, 2:06 p.m.
Message ID <69541cab1dcd4e9f5e8a.1450361200@mimosa>
Download mbox | patch
Permalink /patch/12095/
State Accepted
Headers show

Comments

Yuya Nishihara - Dec. 17, 2015, 2:06 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1450358981 -32400
#      Thu Dec 17 22:29:41 2015 +0900
# Node ID 69541cab1dcd4e9f5e8a137bf53b034da825af5c
# Parent  4f2b6ddb431d921fe3d05d557a7334b76c2f4990
help: add missed last new line to "internals" topic

Caught by test-gendoc.t.
Matt Mackall - Dec. 17, 2015, 11:09 p.m.
On Thu, 2015-12-17 at 23:06 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1450358981 -32400
> #      Thu Dec 17 22:29:41 2015 +0900
> # Node ID 69541cab1dcd4e9f5e8a137bf53b034da825af5c
> # Parent  4f2b6ddb431d921fe3d05d557a7334b76c2f4990
> help: add missed last new line to "internals" topic

Queued for default, thanks. Looks to be a docutils version issue.

-- 
Mathematics is the supreme nostalgia of our time.

Patch

diff --git a/mercurial/help.py b/mercurial/help.py
--- a/mercurial/help.py
+++ b/mercurial/help.py
@@ -174,9 +174,9 @@  def internalshelp(ui):
     """Generate the index for the "internals" topic."""
     lines = []
     for names, header, doc in internalstable:
-        lines.append(' :%s: %s' % (names[0], header))
+        lines.append(' :%s: %s\n' % (names[0], header))
 
-    return '\n'.join(lines)
+    return ''.join(lines)
 
 helptable = sorted([
     (["config", "hgrc"], _("Configuration Files"), loaddoc('config')),