Patchwork pathencode: remove an unused assignment

login
register
mail settings
Submitter Bryan O'Sullivan
Date Dec. 13, 2015, 5:01 a.m.
Message ID <95e3483bc3f839d684a6.1449982910@bryano-mbp.netgear.com>
Download mbox | patch
Permalink /patch/12000/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

Bryan O'Sullivan - Dec. 13, 2015, 5:01 a.m.
# HG changeset patch
# User Bryan O'Sullivan <bos@serpentine.com>
# Date 1449982777 28800
#      Sat Dec 12 20:59:37 2015 -0800
# Node ID 95e3483bc3f839d684a624eef07bf169ab32e468
# Parent  f9d7c5483dbb148a0895867a601f8d0920379be2
pathencode: remove an unused assignment
Yuya Nishihara - Dec. 13, 2015, 8:21 a.m.
On Sat, 12 Dec 2015 21:01:50 -0800, Bryan O'Sullivan wrote:
> # HG changeset patch
> # User Bryan O'Sullivan <bos@serpentine.com>
> # Date 1449982777 28800
> #      Sat Dec 12 20:59:37 2015 -0800
> # Node ID 95e3483bc3f839d684a624eef07bf169ab32e468
> # Parent  f9d7c5483dbb148a0895867a601f8d0920379be2
> pathencode: remove an unused assignment

Looks good, will push to the clowncopter, thanks.

Patch

diff --git a/mercurial/pathencode.c b/mercurial/pathencode.c
--- a/mercurial/pathencode.c
+++ b/mercurial/pathencode.c
@@ -517,8 +517,7 @@  PyObject *lowerencode(PyObject *self, Py
 	newlen = _lowerencode(NULL, 0, path, len);
 	ret = PyString_FromStringAndSize(NULL, newlen);
 	if (ret)
-		newlen = _lowerencode(PyString_AS_STRING(ret), newlen,
-				      path, len);
+		_lowerencode(PyString_AS_STRING(ret), newlen, path, len);
 
 	return ret;
 }