Patchwork [3,of,3] help: fix help -c/help -e/help -k

login
register
mail settings
Submitter timeless@mozdev.org
Date Dec. 9, 2015, 7:24 p.m.
Message ID <7e75db1c2e699cd7cfc9.1449689045@waste.org>
Download mbox | patch
Permalink /patch/11954/
State Accepted
Headers show

Comments

timeless@mozdev.org - Dec. 9, 2015, 7:24 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1449640614 0
#      Wed Dec 09 05:56:54 2015 +0000
# Node ID 7e75db1c2e699cd7cfc92992850df9a787180813
# Parent  cb8a737055a013a3c02c62825ae074a1af0513a4
help: fix help -c/help -e/help -k

Before, hg help -c was the same as hg help, now it only shows commands.
Before, hg help -e was the same as hg help, now it only shows extensions.
Before, hg help -k crashed, now it shows all topics.
Pierre-Yves David - Dec. 10, 2015, 9 p.m.
On 12/09/2015 07:24 PM, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1449640614 0
> #      Wed Dec 09 05:56:54 2015 +0000
> # Node ID 7e75db1c2e699cd7cfc92992850df9a787180813
> # Parent  cb8a737055a013a3c02c62825ae074a1af0513a4
> help: fix help -c/help -e/help -k

pushed to the clowncopter with a couple of fix.


> @@ -374,7 +374,8 @@
>               else:
>                   rst.append(' :%s: %s\n' % (f, h[f]))
>
> -        if not name:
> +        if not name and (opts.get('keyword') or not
> +                         (opts.get('command') or opts.get('extension'))):
>               exts = listexts(_('enabled extensions:'), extensions.enabled())
>               if exts:
>                   rst.append('\n')

I made computed the right side of the "and" in a dedicated variable.


> @@ -491,8 +492,8 @@
>
>       rst = []
>       kw = opts.get('keyword')
> -    if kw:
> -        matches = topicmatch(ui, name)
> +    if kw or name is None and {(o, opts[o]) for o in opts if opts[o]}:
> +        matches = topicmatch(ui, name or '')
>           helpareas = []
>           if opts.get('extension'):
>               helpareas += [('extensions', _('Extensions'))]

I've remove the strange set comprehension (2.7 only) by a simpler:

   any(opts[o] for o in opts)

Patch

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -854,7 +854,7 @@ 
     if options['version']:
         return commands.version_(ui)
     if options['help']:
-        return commands.help_(ui, cmd, command=True)
+        return commands.help_(ui, cmd, command=cmd is not None)
     elif not cmd:
         return commands.help_(ui, 'shortlist')
 
diff --git a/mercurial/help.py b/mercurial/help.py
--- a/mercurial/help.py
+++ b/mercurial/help.py
@@ -328,7 +328,7 @@ 
         return rst
 
 
-    def helplist(select=None):
+    def helplist(select=None, **opts):
         # list of commands
         if name == "shortlist":
             header = _('basic commands:\n\n')
@@ -374,7 +374,8 @@ 
             else:
                 rst.append(' :%s: %s\n' % (f, h[f]))
 
-        if not name:
+        if not name and (opts.get('keyword') or not
+                         (opts.get('command') or opts.get('extension'))):
             exts = listexts(_('enabled extensions:'), extensions.enabled())
             if exts:
                 rst.append('\n')
@@ -491,8 +492,8 @@ 
 
     rst = []
     kw = opts.get('keyword')
-    if kw:
-        matches = topicmatch(ui, name)
+    if kw or name is None and {(o, opts[o]) for o in opts if opts[o]}:
+        matches = topicmatch(ui, name or '')
         helpareas = []
         if opts.get('extension'):
             helpareas += [('extensions', _('Extensions'))]
@@ -539,6 +540,6 @@ 
         # program name
         if not ui.quiet:
             rst = [_("Mercurial Distributed SCM\n"), '\n']
-        rst.extend(helplist())
+        rst.extend(helplist(None, **opts))
 
     return ''.join(rst)
diff --git a/tests/test-help.t b/tests/test-help.t
--- a/tests/test-help.t
+++ b/tests/test-help.t
@@ -1053,6 +1053,15 @@ 
 
 Test -e / -c / -k combinations
 
+  $ hg help -c|egrep '^\S|debug'
+  Commands:
+  $ hg help -e|egrep '^\S'
+  Extensions:
+  $ hg help -k|egrep '^\S'
+  Topics:
+  Commands:
+  Extensions:
+  Extension Commands:
   $ hg help -c schemes
   abort: no such help topic: schemes
   (try "hg help --keyword schemes")