Patchwork [4,of,5] bookmark: deprecate 'bmstore.write' method

login
register
mail settings
Submitter Pierre-Yves David
Date Dec. 6, 2015, 8:45 p.m.
Message ID <b7102e200b8b952350d0.1449434714@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/11864/
State Superseded
Commit 38024b75241a56e8f94d4ba33e0aed2807e5b07e
Delegated to: Yuya Nishihara
Headers show

Comments

Pierre-Yves David - Dec. 6, 2015, 8:45 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1449387247 28800
#      Sat Dec 05 23:34:07 2015 -0800
# Node ID b7102e200b8b952350d0202cdb43429dc60123bd
# Parent  4a7698acef2b110fc6b64c00db77e9ca2d82da76
# EXP-Topic deprecationwarning
# Available At http://hg.netv6.net/marmoute-wip/mercurial/
#              hg pull http://hg.netv6.net/marmoute-wip/mercurial/ -r b7102e200b8b
bookmark: deprecate 'bmstore.write' method

This function does not collaborate with the transaction and must disappear. As
we have likely a lot of third party users, we make it deprecated to let them some
time to upgrade their code.

Thanks goes to Laurent Charignon for cleanup the last remains of the 'write'
method.

Patch

diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
--- a/mercurial/bookmarks.py
+++ b/mercurial/bookmarks.py
@@ -103,10 +103,12 @@  class bmstore(dict):
         in a format equal to those of localtags.
 
         We also store a backup of the previous state in undo.bookmarks that
         can be copied back on rollback.
         '''
+        msg = 'bm.write() is deprecated, use bm.recordchange(transaction)'
+        self._repo.ui.deprecwarn(msg, '3.7')
         if self._clean:
             return
         repo = self._repo
         if (repo.ui.configbool('devel', 'all-warnings')
                 or repo.ui.configbool('devel', 'check-locks')):