Patchwork [2,of,6] changegroup: drop 'if True' that made the previous change clearer

login
register
mail settings
Submitter Augie Fackler
Date Dec. 4, 2015, 7:20 p.m.
Message ID <ef0693b1540667fd183f.1449256837@arthedain.pit.corp.google.com>
Download mbox | patch
Permalink /patch/11810/
State Superseded
Headers show

Comments

Augie Fackler - Dec. 4, 2015, 7:20 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1449243345 18000
#      Fri Dec 04 10:35:45 2015 -0500
# Node ID ef0693b1540667fd183fe1364dbf308f919a0fd6
# Parent  bfdd624c667b6f72f2069a3537becad05e162c08
# EXP-Topic cg3
changegroup: drop 'if True' that made the previous change clearer

Patch

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -673,17 +673,16 @@  class cg1packer(object):
             if not fastpathlinkrev:
                 mdata = ml.readfast(x)
                 for f in mfchangedfiles[x]:
-                    if True:
-                        try:
-                            n = mdata[f]
-                        except KeyError:
-                            continue
-                        # record the first changeset introducing this filelog
-                        # version
-                        fclnodes = fnodes.setdefault(f, {})
-                        fclnode = fclnodes.setdefault(n, clnode)
-                        if clrevorder[clnode] < clrevorder[fclnode]:
-                            fclnodes[n] = clnode
+                    try:
+                        n = mdata[f]
+                    except KeyError:
+                        continue
+                    # record the first changeset introducing this filelog
+                    # version
+                    fclnodes = fnodes.setdefault(f, {})
+                    fclnode = fclnodes.setdefault(n, clnode)
+                    if clrevorder[clnode] < clrevorder[fclnode]:
+                        fclnodes[n] = clnode
             return clnode
 
         mfnodes = self.prune(ml, mfs, commonrevs)