Patchwork [4,of,4] histedit: RFC raise

login
register
mail settings
Submitter timeless@mozdev.org
Date Dec. 2, 2015, 8:13 a.m.
Message ID <355ddc805cf3ca8a0b08.1449044016@waste.org>
Download mbox | patch
Permalink /patch/11738/
State Accepted
Headers show

Comments

timeless@mozdev.org - Dec. 2, 2015, 8:13 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1449042042 0
#      Wed Dec 02 07:40:42 2015 +0000
# Node ID 355ddc805cf3ca8a0b087ca1cf6e7f9962be9bf7
# Parent  6c1a9a53f7c441b4ef68b7e891249539c702b2ae
histedit: RFC raise ...

I'm not sure what this is doing, but it seems wrong
Mateusz Kwapich - Dec. 2, 2015, 4:58 p.m.
Sorry for that clown.




On 12/2/15, 12:13 AM, "Mercurial-devel on behalf of timeless" <mercurial-devel-bounces@selenic.com on behalf of timeless@mozdev.org> wrote:

># HG changeset patch

># User timeless <timeless@mozdev.org>

># Date 1449042042 0

>#      Wed Dec 02 07:40:42 2015 +0000

># Node ID 355ddc805cf3ca8a0b087ca1cf6e7f9962be9bf7

># Parent  6c1a9a53f7c441b4ef68b7e891249539c702b2ae

>histedit: RFC raise ...

>

>I'm not sure what this is doing, but it seems wrong

>

>diff --git a/hgext/histedit.py b/hgext/histedit.py

>--- a/hgext/histedit.py

>+++ b/hgext/histedit.py

>@@ -1113,7 +1113,7 @@

>         constraints = action.constraints()

>         for constraint in constraints:

>             if constraint not in _constraints.known():

>-                error.Abort(_('unknown constraint "%s"') % constraint)

>+                raise error.Abort(_('unknown constraint "%s"') % constraint)

> 

>         nodetoverify = action.nodetoverify()

>         if nodetoverify is not None:

>_______________________________________________

>Mercurial-devel mailing list

>Mercurial-devel@selenic.com

>https://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -1113,7 +1113,7 @@ 
         constraints = action.constraints()
         for constraint in constraints:
             if constraint not in _constraints.known():
-                error.Abort(_('unknown constraint "%s"') % constraint)
+                raise error.Abort(_('unknown constraint "%s"') % constraint)
 
         nodetoverify = action.nodetoverify()
         if nodetoverify is not None: