Patchwork [0,of,9] hgk: further improvements

login
register
mail settings
Submitter Sean Farley
Date March 22, 2013, 10:43 p.m.
Message ID <m21ub7awdc.fsf@gmail.com>
Download mbox | patch
Permalink /patch/1167/
State Not Applicable, archived
Headers show

Comments

Sean Farley - March 22, 2013, 10:43 p.m.
Bryan O'Sullivan writes:

> On Sun, Mar 10, 2013 at 9:24 AM, Andrew Shadura <bugzilla@tut.by> wrote:
>
>> Re-sending some patches, adding some new.
>>
>
> Series applied, thanks.

This gives a pyflakes error for me:

Mercurial-devel@selenic.com
http://selenic.com/mailman/listinfo/mercurial-devel
Andrew Shadura - March 22, 2013, 10:49 p.m.
Hello,

On Fri, 22 Mar 2013 17:43:43 -0500
Sean Farley <sean.michael.farley@gmail.com> wrote:

> --- /home/sean/projects/hg/tests/test-check-pyflakes.t
> +++ /home/sean/projects/hg/tests/test-check-pyflakes.t.err
> @@ -1,6 +1,7 @@
>    $ "$TESTDIR/hghave" pyflakes || exit 80
>    $ cd "`dirname "$TESTDIR"`"
>    $ pyflakes mercurial hgext 2>&1 | "$TESTDIR/filterpyflakes.py"
> -  hgext/inotify/linux/__init__.py:*: 'from _inotify import *' used;
> unable to detect undefined names (glob)
> +  hgext/hgk.py:38: 'phases' imported but unused
> +  hgext/inotify/linux/__init__.py:22: 'from _inotify import *' used;
> unable to detect undefined names

Well, yes, probably phases can be dropped from imports. It used to be
needed, but it seems it's not now.

Patch

--- /home/sean/projects/hg/tests/test-check-pyflakes.t
+++ /home/sean/projects/hg/tests/test-check-pyflakes.t.err
@@ -1,6 +1,7 @@ 
   $ "$TESTDIR/hghave" pyflakes || exit 80
   $ cd "`dirname "$TESTDIR"`"
   $ pyflakes mercurial hgext 2>&1 | "$TESTDIR/filterpyflakes.py"
-  hgext/inotify/linux/__init__.py:*: 'from _inotify import *' used; unable to detect undefined names (glob)
+  hgext/hgk.py:38: 'phases' imported but unused
+  hgext/inotify/linux/__init__.py:22: 'from _inotify import *' used; unable to detect undefined names
_______________________________________________
Mercurial-devel mailing list