Patchwork [1,of,6,import-refactor,V2] setup: remove unused py_modules argument to setup()

login
register
mail settings
Submitter Gregory Szorc
Date Nov. 25, 2015, 7:31 a.m.
Message ID <82b37470a224dc1e496b.1448436705@ubuntu-main>
Download mbox | patch
Permalink /patch/11651/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

Gregory Szorc - Nov. 25, 2015, 7:31 a.m.
# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1448428646 28800
#      Tue Nov 24 21:17:26 2015 -0800
# Node ID 82b37470a224dc1e496b86b0ba14df391a3f3ecd
# Parent  61fbf5dc12b23e7a2a30cf04ebd9f096c42a1f61
setup: remove unused py_modules argument to setup()

It is never populated and is useless clutter.
Yuya Nishihara - Nov. 29, 2015, 5:15 a.m.
On Tue, 24 Nov 2015 23:31:45 -0800, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1448428646 28800
> #      Tue Nov 24 21:17:26 2015 -0800
> # Node ID 82b37470a224dc1e496b86b0ba14df391a3f3ecd
> # Parent  61fbf5dc12b23e7a2a30cf04ebd9f096c42a1f61
> setup: remove unused py_modules argument to setup()

I'll push only this to the clowncopter.

Patch

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -478,18 +478,16 @@  cmdclass = {'build': hgbuild,
             'install_scripts': hginstallscripts,
             'build_hgexe': buildhgexe,
             }
 
 packages = ['mercurial', 'mercurial.hgweb', 'mercurial.httpclient',
             'hgext', 'hgext.convert', 'hgext.highlight', 'hgext.zeroconf',
             'hgext.largefiles']
 
-pymodules = []
-
 common_depends = ['mercurial/util.h']
 
 osutil_ldflags = []
 
 if sys.platform == 'darwin':
     osutil_ldflags += ['-framework', 'ApplicationServices']
 
 extmodules = [
@@ -631,17 +629,16 @@  setup(name='mercurial',
           'Operating System :: OS Independent',
           'Operating System :: POSIX',
           'Programming Language :: C',
           'Programming Language :: Python',
           'Topic :: Software Development :: Version Control',
       ],
       scripts=scripts,
       packages=packages,
-      py_modules=pymodules,
       ext_modules=extmodules,
       data_files=datafiles,
       package_data=packagedata,
       cmdclass=cmdclass,
       distclass=hgdist,
       options={'py2exe': {'packages': ['hgext', 'email']},
                'bdist_mpkg': {'zipdist': False,
                               'license': 'COPYING',