Patchwork [2,of,3] contrib/gpg: rename sigcheck function

login
register
mail settings
Submitter timeless@mozdev.org
Date Nov. 25, 2015, 6:31 a.m.
Message ID <a6abc5a4a6f757cca55f.1448433099@waste.org>
Download mbox | patch
Permalink /patch/11649/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

timeless@mozdev.org - Nov. 25, 2015, 6:31 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1448431854 0
#      Wed Nov 25 06:10:54 2015 +0000
# Node ID a6abc5a4a6f757cca55f6db68520f934e0fa4057
# Parent  3959884258260babbfe1adc4020665dee12b0703
contrib/gpg: rename sigcheck function

I see no reason for the function not to be sigcheck ...
Yuya Nishihara - Nov. 28, 2015, 1:59 p.m.
On Wed, 25 Nov 2015 00:31:39 -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1448431854 0
> #      Wed Nov 25 06:10:54 2015 +0000
> # Node ID a6abc5a4a6f757cca55f6db68520f934e0fa4057
> # Parent  3959884258260babbfe1adc4020665dee12b0703
> contrib/gpg: rename sigcheck function
> 
> I see no reason for the function not to be sigcheck ...
> 
> diff --git a/hgext/gpg.py b/hgext/gpg.py
> --- a/hgext/gpg.py
> +++ b/hgext/gpg.py
> @@ -167,8 +167,11 @@
>              r = "%5d:%s" % (rev, hgnode.hex(repo.changelog.node(rev)))
>              ui.write("%-30s %s\n" % (keystr(ui, k), r))
>  
> +def check(ui, repo, rev):
> +    sigcheck(ui, repo, rev)
> +

and no reason to keep check() ?
Removed it and pushed this to the clowncopter, thanks.

>  @command("sigcheck", [], _('hg sigcheck REV'))
> -def check(ui, repo, rev):
> +def sigcheck(ui, repo, rev):

Patch

diff --git a/hgext/gpg.py b/hgext/gpg.py
--- a/hgext/gpg.py
+++ b/hgext/gpg.py
@@ -167,8 +167,11 @@ 
             r = "%5d:%s" % (rev, hgnode.hex(repo.changelog.node(rev)))
             ui.write("%-30s %s\n" % (keystr(ui, k), r))
 
+def check(ui, repo, rev):
+    sigcheck(ui, repo, rev)
+
 @command("sigcheck", [], _('hg sigcheck REV'))
-def check(ui, repo, rev):
+def sigcheck(ui, repo, rev):
     """verify all the signatures there may be for a particular revision"""
     mygpg = newgpg(ui)
     rev = repo.lookup(rev)