Patchwork [5,of,5,v2] check-code allow argument passing py2.6ism

login
register
mail settings
Submitter timeless@mozdev.org
Date Oct. 20, 2015, 12:34 a.m.
Message ID <5764f11cee4c6b9dcfac.1445301296@waste.org>
Download mbox | patch
Permalink /patch/11205/
State Accepted
Headers show

Comments

timeless@mozdev.org - Oct. 20, 2015, 12:34 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1444944506 14400
#      Thu Oct 15 17:28:26 2015 -0400
# Node ID 5764f11cee4c6b9dcfac0585f4a3ed645ef84404
# Parent  17ed74e8d8ef62ee19bb289b3dc2f0dbb5e321d7
check-code allow argument passing py2.6ism

this backs out 131f7fe06e9e, because Python2.5 support was dropped
Matt Mackall - Oct. 20, 2015, 7:20 p.m.
On Mon, 2015-10-19 at 19:34 -0500, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1444944506 14400
> #      Thu Oct 15 17:28:26 2015 -0400
> # Node ID 5764f11cee4c6b9dcfac0585f4a3ed645ef84404
> # Parent  17ed74e8d8ef62ee19bb289b3dc2f0dbb5e321d7
> check-code allow argument passing py2.6ism

These are queued for default, thanks. Please note that the freeze
should have started two days ago, so these are only being accepted
because we had release-blocking regressions I've been waiting on fixes
for.

-- 
Mathematics is the supreme nostalgia of our time.

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -199,7 +199,6 @@ 
 
 pypats = [
   [
-    (r'\([^)]*\*\w[^()]+\w+=', "can't pass varargs with keyword in Py2.5"),
     (r'^\s*def\s*\w+\s*\(.*,\s*\(',
      "tuple parameter unpacking not available in Python 3+"),
     (r'lambda\s*\(.*,.*\)',