Patchwork [2,of,2] check-code: block non-portable pipe-and

login
register
mail settings
Submitter timeless@mozdev.org
Date Oct. 16, 2015, 12:39 a.m.
Message ID <728636bf5221c5ddcca2.1444955947@waste.org>
Download mbox | patch
Permalink /patch/11129/
State Accepted
Headers show

Comments

timeless@mozdev.org - Oct. 16, 2015, 12:39 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1444955772 14400
#      Thu Oct 15 20:36:12 2015 -0400
# Node ID 728636bf5221c5ddcca21cb83d51b5954e8e7566
# Parent  abfb14db2b1492217ff3b97a734847385ea530f1
check-code: block non-portable pipe-and
Matt Mackall - Oct. 18, 2015, 11:16 p.m.
On Thu, 2015-10-15 at 19:39 -0500, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1444955772 14400
> #      Thu Oct 15 20:36:12 2015 -0400
> # Node ID 728636bf5221c5ddcca21cb83d51b5954e8e7566
> # Parent  abfb14db2b1492217ff3b97a734847385ea530f1
> check-code: block non-portable pipe-and

These are queued for default, thanks.

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -125,6 +125,7 @@ 
     (r'^diff *-\w*u.*$\n(^  \$ |^$)', "prefix diff -u with cmp"),
     (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
     (r'\butil\.Abort\b', "directly use error.Abort"),
+    (r'\|&', "don't use |&, use 2>&1"),
   ],
   # warnings
   [