Patchwork [10,of,10] changegroup: delete now-unused addchangegroup method

login
register
mail settings
Submitter Augie Fackler
Date Oct. 14, 2015, 5:34 p.m.
Message ID <3f238fd1bf851ab14c5b.1444844075@augie-macbookair2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/11059/
State Accepted
Headers show

Comments

Augie Fackler - Oct. 14, 2015, 5:34 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1444770877 14400
#      Tue Oct 13 17:14:37 2015 -0400
# Node ID 3f238fd1bf851ab14c5b6a4ae8a88e55d6dd8b15
# Parent  166d8cee14236633f130cb2ef91d91251243f665
changegroup: delete now-unused addchangegroup method
Pierre-Yves David - Oct. 15, 2015, 2:13 p.m.
On 10/14/2015 06:34 PM, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1444770877 14400
> #      Tue Oct 13 17:14:37 2015 -0400
> # Node ID 3f238fd1bf851ab14c5b6a4ae8a88e55d6dd8b15
> # Parent  166d8cee14236633f130cb2ef91d91251243f665
> changegroup: delete now-unused addchangegroup method

This series and changesets after it looks good to me, but fail to 
rebase. I've deferred the rebase to Augie and I expect him to push the 
result.

Patch

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -909,12 +909,3 @@  def addchangegroupfiles(repo, source, re
                     (f, hex(n)))
 
     return revisions, files
-
-def addchangegroup(repo, source, srctype, url, emptyok=False,
-                   targetphase=phases.draft, expectedtotal=None):
-    """Legacy forwarding method to cg?unpacker.apply() to be removed soon."""
-    if not source:
-        return 0
-
-    return source.apply(repo, srctype, url, emptyok=emptyok,
-                        targetphase=targetphase, expectedtotal=expectedtotal)