Patchwork [1,of,3,V2] update: move default destination computation to a function

login
register
mail settings
Submitter Pierre-Yves David
Date Oct. 8, 2015, 7:09 p.m.
Message ID <626558e252ef35fab8cc.1444331385@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/10887/
State Accepted
Headers show

Comments

Pierre-Yves David - Oct. 8, 2015, 7:09 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1444034807 25200
#      Mon Oct 05 01:46:47 2015 -0700
# Node ID 626558e252ef35fab8ccebaad863f08ad3f0839b
# Parent  e046fdb26b5b28e72231782fed842a003627c057
update: move default destination computation to a function

We ultimately want this to be accessible through a revset, but there is too
much complexity here for that to work. Especially we'll have to return more
than just the destination to control the behavior (eg: bookmarks to activate,
etc).

To prevent cycle, a new module is created, it will receive other
destination/behavior function in the future.

Patch

diff --git a/mercurial/destutil.py b/mercurial/destutil.py
new file mode 100644
--- /dev/null
+++ b/mercurial/destutil.py
@@ -0,0 +1,56 @@ 
+# destutil.py - Mercurial utility function for command destination
+#
+#  Copyright Matt Mackall <mpm@selenic.com> and other
+#
+# This software may be used and distributed according to the terms of the
+# GNU General Public License version 2 or any later version.
+
+from .i18n import _
+from . import (
+    error,
+    util,
+    obsolete,
+)
+
+def destupdate(repo):
+    """destination for bare update operation
+    """
+    # Here is where we should consider bookmarks, divergent bookmarks, and tip
+    # of current branch; but currently we are only checking the branch tips.
+    node = None
+    wc = repo[None]
+    p1 = wc.p1()
+    try:
+        node = repo.branchtip(wc.branch())
+    except error.RepoLookupError:
+        if wc.branch() == 'default': # no default branch!
+            node = repo.lookup('tip') # update to tip
+        else:
+            raise util.Abort(_("branch %s not found") % wc.branch())
+
+    if p1.obsolete() and not p1.children():
+        # allow updating to successors
+        successors = obsolete.successorssets(repo, p1.node())
+
+        # behavior of certain cases is as follows,
+        #
+        # divergent changesets: update to highest rev, similar to what
+        #     is currently done when there are more than one head
+        #     (i.e. 'tip')
+        #
+        # replaced changesets: same as divergent except we know there
+        # is no conflict
+        #
+        # pruned changeset: no update is done; though, we could
+        #     consider updating to the first non-obsolete parent,
+        #     similar to what is current done for 'hg prune'
+
+        if successors:
+            # flatten the list here handles both divergent (len > 1)
+            # and the usual case (len = 1)
+            successors = [n for sub in successors for n in sub]
+
+            # get the max revision for the given successors set,
+            # i.e. the 'tip' of a set
+            node = repo.revs('max(%ln)', successors).first()
+    return repo[node].rev()
diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -10,10 +10,11 @@  from __future__ import absolute_import
 import heapq
 import re
 
 from .i18n import _
 from . import (
+    destutil,
     encoding,
     error,
     hbisect,
     match as matchmod,
     node,
@@ -530,50 +531,12 @@  def _updatedefaultdest(repo, subset, x):
     # default destination for update.
     # # XXX: Currently private because I expect the signature to change.
     # # XXX: - taking rev as arguments,
     # # XXX: - bailing out in case of ambiguity vs returning all data.
     getargs(x, 0, 0, _("_updatedefaultdest takes no arguments"))
-    # Here is where we should consider bookmarks, divergent bookmarks,
-    # foreground changesets (successors), and tip of current branch;
-    # but currently we are only checking the branch tips.
-    node = None
-    wc = repo[None]
-    p1 = wc.p1()
-    try:
-        node = repo.branchtip(wc.branch())
-    except error.RepoLookupError:
-        if wc.branch() == 'default': # no default branch!
-            node = repo.lookup('tip') # update to tip
-        else:
-            raise util.Abort(_("branch %s not found") % wc.branch())
-
-    if p1.obsolete() and not p1.children():
-        # allow updating to successors
-        successors = obsmod.successorssets(repo, p1.node())
-
-        # behavior of certain cases is as follows,
-        #
-        # divergent changesets: update to highest rev, similar to what
-        #     is currently done when there are more than one head
-        #     (i.e. 'tip')
-        #
-        # replaced changesets: same as divergent except we know there
-        # is no conflict
-        #
-        # pruned changeset: no update is done; though, we could
-        #     consider updating to the first non-obsolete parent,
-        #     similar to what is current done for 'hg prune'
-
-        if successors:
-            # flatten the list here handles both divergent (len > 1)
-            # and the usual case (len = 1)
-            successors = [n for sub in successors for n in sub]
-
-            # get the max revision for the given successors set,
-            # i.e. the 'tip' of a set
-            node = repo.revs('max(%ln)', successors).first()
-    return subset & baseset([repo[node].rev()])
+    rev = destutil.destupdate(repo)
+    return subset & baseset([rev])
 
 def adds(repo, subset, x):
     """``adds(pattern)``
     Changesets that add a file matching pattern.