Patchwork [Bug,4876] New: test-commandserver fails frequently on OS X

login
register
mail settings
Submitter mercurial-bugs@selenic.com
Date Oct. 2, 2015, 4:02 p.m.
Message ID <bug-4876-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/10736/
State Not Applicable
Headers show

Comments

mercurial-bugs@selenic.com - Oct. 2, 2015, 4:02 p.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=4876

            Bug ID: 4876
           Summary: test-commandserver fails frequently on OS X
           Product: Mercurial
           Version: default branch
          Hardware: Macintosh
                OS: Mac OS
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: Mercurial
          Assignee: bugzilla@selenic.com
          Reporter: matt_harbison@yahoo.com
                CC: mercurial-devel@selenic.com, yuya@tcha.org

It seems to fail for me on 10.10 more than 50% of the time, but there are
definitely runs where it passes.


   $ cat >> .hg/hgrc << EOF

ERROR: test-commandserver.t output changed
!


I bisected it back to here:

changeset:   26406:5c0f5db65c6b
user:        Yuya Nishihara <yuya@tcha.org>
date:        Tue Sep 15 00:32:39 2015 +0900
summary:     localrepo: refresh filecache stats only if transaction finished
successfully

The test on the parent of this passed 100 times in a row, so I'm sure I
bisected this properly.

Patch

--- /usr/local/mercurial/tests/test-commandserver.t
+++ /usr/local/mercurial/tests/test-commandserver.t.err
@@ -433,10 +433,18 @@ 
    [255]
   *** runcommand verify
   checking changesets
+   2: unpacking changeset 04f617292b91: [Errno 2] No such file or directory:
'$TESTTMP/repo/.hg/store/00changelog.i.a'
   checking manifests
+   manifest@?: index contains -108 extra bytes
+   manifest@?: rev 2 points to unexpected changeset 2
+   manifest@?: f4054e1bdfb4 not in changesets
+   ?: reading manifest delta f4054e1bdfb4: integrity check failed on
00manifest.i:2
   crosschecking files in changesets and manifests
   checking files
-  1 files, 2 changesets, 2 total revisions
+  1 files, 3 changesets, 2 total revisions
+  5 integrity errors encountered!
+  (first damaged changeset appears to be 2)
+   [1]
   $ hg revert --no-backup -aq