From patchwork Sat Sep 26 05:27:57 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [2, of,
 2] formatter: use dict.update() to set arguments passed to write
 functions
From: Yuya Nishihara <yuya@tcha.org>
X-Patchwork-Id: 10653
Message-Id: <7a6f477ee7ffac05e01d.1443245277@mimosa>
To: mercurial-devel@selenic.com
Date: Sat, 26 Sep 2015 14:27:57 +0900

# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1443012887 -32400
#      Wed Sep 23 21:54:47 2015 +0900
# Node ID 7a6f477ee7ffac05e01db296a2a71cc56bece8ba
# Parent  bca566c50dc08a27c25d28cc138bc8197b2b7c5b
formatter: use dict.update() to set arguments passed to write functions

This isn't important, but update() is better than loop in general.

diff --git a/mercurial/formatter.py b/mercurial/formatter.py
--- a/mercurial/formatter.py
+++ b/mercurial/formatter.py
@@ -50,14 +50,12 @@ class baseformatter(object):
         '''do default text output while assigning data to item'''
         fieldkeys = fields.split()
         assert len(fieldkeys) == len(fielddata)
-        for k, v in zip(fieldkeys, fielddata):
-            self._item[k] = v
+        self._item.update(zip(fieldkeys, fielddata))
     def condwrite(self, cond, fields, deftext, *fielddata, **opts):
         '''do conditional write (primarily for plain formatter)'''
         fieldkeys = fields.split()
         assert len(fieldkeys) == len(fielddata)
-        for k, v in zip(fieldkeys, fielddata):
-            self._item[k] = v
+        self._item.update(zip(fieldkeys, fielddata))
     def plain(self, text, **opts):
         '''show raw text for non-templated mode'''
         pass