Patchwork [5,of,5,remotefilelog-ext,debs] Makefile: add `make deb` rule for convenience

login
register
mail settings
Submitter Augie Fackler
Date Sept. 10, 2015, 3:34 p.m.
Message ID <937116e5408258b3d359.1441899263@arthedain.pit.corp.google.com>
Download mbox | patch
Permalink /patch/10470/
State Accepted
Headers show

Comments

Augie Fackler - Sept. 10, 2015, 3:34 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1441899102 14400
#      Thu Sep 10 11:31:42 2015 -0400
# Node ID 937116e5408258b3d359cc486218e966557aeed7
# Parent  9fec75539a1e42cee876b481f1e748dafc1f347c
Makefile: add `make deb` rule for convenience

This matches what Mercurial has, so I figure we may as well be
consistent.
Durham Goode - Sept. 10, 2015, 8:40 p.m.
On 9/10/15, 8:34 AM, "Augie Fackler" <raf@durin42.com> wrote:



># HG changeset patch

># User Augie Fackler <augie@google.com>

># Date 1441899102 14400

>#      Thu Sep 10 11:31:42 2015 -0400

># Node ID 937116e5408258b3d359cc486218e966557aeed7

># Parent  9fec75539a1e42cee876b481f1e748dafc1f347c

>Makefile: add `make deb` rule for convenience

>

>This matches what Mercurial has, so I figure we may as well be

>consistent.

>

>diff --git a/Makefile b/Makefile

>--- a/Makefile

>+++ b/Makefile

>@@ -20,3 +20,6 @@ install:

> clean:

> 	-$(PYTHON) setup.py clean --all # ignore errors from this command

> 	find . \( -name '*.py[cdo]' -o -name '*.so' \) -exec rm -f '{}' ';'

>+

>+deb:

>+	contrib/builddeb


I've pushed all 5 patches.  Feel free to send a fixer-upper if you want to address the mercurial dependency and the Architecture spec things you mentioned.  I don't have a strong opinion there since my knowledge of packaging is pretty weak.
Augie Fackler - Sept. 10, 2015, 9:27 p.m.
Alrighty, will do. Thanks for the quick response!

> On Sep 10, 2015, at 4:40 PM, Durham Goode <durham@fb.com> wrote:
> 
> On 9/10/15, 8:34 AM, "Augie Fackler" <raf@durin42.com> wrote:
> 
> 
> 
>> # HG changeset patch
>> # User Augie Fackler <augie@google.com>
>> # Date 1441899102 14400
>> #      Thu Sep 10 11:31:42 2015 -0400
>> # Node ID 937116e5408258b3d359cc486218e966557aeed7
>> # Parent  9fec75539a1e42cee876b481f1e748dafc1f347c
>> Makefile: add `make deb` rule for convenience
>> 
>> This matches what Mercurial has, so I figure we may as well be
>> consistent.
>> 
>> diff --git a/Makefile b/Makefile
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -20,3 +20,6 @@ install:
>> clean:
>> 	-$(PYTHON) setup.py clean --all # ignore errors from this command
>> 	find . \( -name '*.py[cdo]' -o -name '*.so' \) -exec rm -f '{}' ';'
>> +
>> +deb:
>> +	contrib/builddeb
> 
> I've pushed all 5 patches.  Feel free to send a fixer-upper if you want to address the mercurial dependency and the Architecture spec things you mentioned.  I don't have a strong opinion there since my knowledge of packaging is pretty weak.

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -20,3 +20,6 @@  install:
 clean:
 	-$(PYTHON) setup.py clean --all # ignore errors from this command
 	find . \( -name '*.py[cdo]' -o -name '*.so' \) -exec rm -f '{}' ';'
+
+deb:
+	contrib/builddeb