Patchwork [1,of,2] tests: append glob to filename output when required for windows

login
register
mail settings
Submitter Simon Heimberg
Date Feb. 23, 2013, 10:10 p.m.
Message ID <3660cfb8b145e88b7722.1361657450@deb64virt.virtual>
Download mbox | patch
Permalink /patch/1045/
State Accepted
Headers show

Comments

Simon Heimberg - Feb. 23, 2013, 10:10 p.m.
# HG changeset patch
# User Simon Heimberg <simohe@besonet.ch>
# Date 1361653658 -3600
# Branch stable
# Node ID 3660cfb8b145e88b77228a1676d5c37113d93595
# Parent  7790d69af6d6bd72b4d5495c6a75abdc75cbeb33
tests: append glob to filename output when required for windows

The test failed on windows before this patch.
Matt Mackall - Feb. 24, 2013, 7:40 p.m.
On Sat, 2013-02-23 at 23:10 +0100, Simon Heimberg wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe@besonet.ch>
> # Date 1361653658 -3600
> # Branch stable
> # Node ID 3660cfb8b145e88b77228a1676d5c37113d93595
> # Parent  7790d69af6d6bd72b4d5495c6a75abdc75cbeb33
> tests: append glob to filename output when required for windows
> 
> The test failed on windows before this patch.

I think I'm going to start insisting that such patches come with
check-code recipes. It's the only hope we have for not hitting these
issues constantly.

Patch

diff -r 7790d69af6d6 -r 3660cfb8b145 tests/test-blackbox.t
--- a/tests/test-blackbox.t	Fri Feb 22 10:05:22 2013 -0800
+++ b/tests/test-blackbox.t	Sat Feb 23 22:07:38 2013 +0100
@@ -48,7 +48,7 @@ 
   adding c
   $ cd ../blackboxtest2
   $ hg pull
-  pulling from $TESTTMP/blackboxtest
+  pulling from $TESTTMP/blackboxtest (glob)
   searching for changes
   adding changesets
   adding manifests