Comments
Patch
@@ -190,7 +190,12 @@ class hgclient(object):
raise ValueError('server already open')
self.server = util.popen(self._args, self._env)
- self._readhello()
+ try:
+ self._readhello()
+ except error.ServerError:
+ ret, serr = self._close()
+ raise error.ServerError('server exited with status %d: %s'
+ % (ret, serr.strip()))
return self
def close(self):
@@ -12,3 +12,14 @@ class test_hglib(common.basetest):
common.basetest.setUp(self)
client2 = hglib.open()
self.client.close()
+
+ def test_open_nonexistent(self):
+ # setup stuff necessary for basetest.tearDown()
+ self.clients = []
+ self._oldopen = hglib.client.hgclient.open
+ try:
+ self.clients.append(hglib.open('inexistent'))
+ # hg 3.5 can't report error (fixed by 7332bf4ae959)
+ #self.fail('ServerError not raised')
+ except hglib.error.ServerError as inst:
+ self.assertTrue('inexistent' in str(inst))