Patchwork [4,of,4] builddeb: actually run make when building the deb (issue4778)

login
register
mail settings
Submitter Augie Fackler
Date Aug. 27, 2015, 9:22 p.m.
Message ID <6209b2def9d873bb33aa.1440710523@imladris.local>
Download mbox | patch
Permalink /patch/10304/
State Accepted
Headers show

Comments

Augie Fackler - Aug. 27, 2015, 9:22 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1440475112 14400
#      Mon Aug 24 23:58:32 2015 -0400
# Node ID 6209b2def9d873bb33aaff941fee4b8ca2be1e7d
# Parent  ad63d0dc43b2062fbc8ef4bbd9bcd40dceec7161
builddeb: actually run make when building the deb (issue4778)

As of this change, we no longer produce broken debs, but I've already
got followups written that will produce much more standard-looking
packages and test the resulting packages.
Pierre-Yves David - Aug. 27, 2015, 9:46 p.m.
On 08/27/2015 02:22 PM, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1440475112 14400
> #      Mon Aug 24 23:58:32 2015 -0400
> # Node ID 6209b2def9d873bb33aaff941fee4b8ca2be1e7d
> # Parent  ad63d0dc43b2062fbc8ef4bbd9bcd40dceec7161
> builddeb: actually run make when building the deb (issue4778)

Seems legit, pushed to the clowncopter.

Patch

diff --git a/contrib/builddeb b/contrib/builddeb
--- a/contrib/builddeb
+++ b/contrib/builddeb
@@ -49,6 +49,7 @@  sed "s/__VERSION__/$version/" < $control
 mv $control.tmp $control
 
 if [ "$BUILD" ]; then
+    make PREFIX=$DEBBUILDDIR/usr install
     dpkg-deb --build $DEBBUILDDIR
     mv $DEBBUILDDIR.deb $DEBBUILDDIR/mercurial-$version-$release.deb
     if [ $? = 0 ]; then