Patchwork revsetbenchmarks: run make after update so that C extensions are built

login
register
mail settings
Submitter Yuya Nishihara
Date Aug. 16, 2015, 2:31 p.m.
Message ID <1d829f802fabcf230e7e.1439735484@mimosa>
Download mbox | patch
Permalink /patch/10220/
State Accepted
Headers show

Comments

Yuya Nishihara - Aug. 16, 2015, 2:31 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1439628659 -32400
#      Sat Aug 15 17:50:59 2015 +0900
# Node ID 1d829f802fabcf230e7e72f7f208d6f6f9284659
# Parent  9e7d805925c87cfa0ca30819e8273ac37fd77a62
revsetbenchmarks: run make after update so that C extensions are built
Sean Farley - Aug. 16, 2015, 7:01 p.m.
Yuya Nishihara <yuya@tcha.org> writes:

> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1439628659 -32400
> #      Sat Aug 15 17:50:59 2015 +0900
> # Node ID 1d829f802fabcf230e7e72f7f208d6f6f9284659
> # Parent  9e7d805925c87cfa0ca30819e8273ac37fd77a62
> revsetbenchmarks: run make after update so that C extensions are built

It's a small patch from Yuya, so by definition, it must be good ;-)
Augie Fackler - Aug. 17, 2015, 6:18 p.m.
On Sun, Aug 16, 2015 at 11:31:24PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1439628659 -32400
> #      Sat Aug 15 17:50:59 2015 +0900
> # Node ID 1d829f802fabcf230e7e72f7f208d6f6f9284659
> # Parent  9e7d805925c87cfa0ca30819e8273ac37fd77a62
> revsetbenchmarks: run make after update so that C extensions are built

Looks sensible. Queued.

>
> diff --git a/contrib/revsetbenchmarks.py b/contrib/revsetbenchmarks.py
> --- a/contrib/revsetbenchmarks.py
> +++ b/contrib/revsetbenchmarks.py
> @@ -33,6 +33,8 @@ def update(rev):
>      """update the repo to a revision"""
>      try:
>          check_call(['hg', 'update', '--quiet', '--check', str(rev)])
> +        check_output(['make', 'local'],
> +                     stderr=None)  # suppress output except for error/warning
>      except CalledProcessError as exc:
>          print >> sys.stderr, 'update to revision %s failed, aborting' % rev
>          sys.exit(exc.returncode)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/contrib/revsetbenchmarks.py b/contrib/revsetbenchmarks.py
--- a/contrib/revsetbenchmarks.py
+++ b/contrib/revsetbenchmarks.py
@@ -33,6 +33,8 @@  def update(rev):
     """update the repo to a revision"""
     try:
         check_call(['hg', 'update', '--quiet', '--check', str(rev)])
+        check_output(['make', 'local'],
+                     stderr=None)  # suppress output except for error/warning
     except CalledProcessError as exc:
         print >> sys.stderr, 'update to revision %s failed, aborting' % rev
         sys.exit(exc.returncode)