Patchwork [STABLE] convert: document convert.hg.startrev

login
register
mail settings
Submitter Matt Harbison
Date July 30, 2015, 1:47 a.m.
Message ID <a9fa08ce71d4b8f3c567.1438220847@Envy>
Download mbox | patch
Permalink /patch/10074/
State Accepted
Commit 6fb55c6c65621b7c4ddd4f82e3e3a14ae5a021d7
Headers show

Comments

Matt Harbison - July 30, 2015, 1:47 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1438219916 14400
#      Wed Jul 29 21:31:56 2015 -0400
# Branch stable
# Node ID a9fa08ce71d4b8f3c567968d2a8986aab64b6524
# Parent  85785cd3b69f09f2e6ffa78dac75d68d08e400bd
convert: document convert.hg.startrev
Augie Fackler - July 30, 2015, 5:07 p.m.
On Wed, Jul 29, 2015 at 09:47:27PM -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1438219916 14400
> #      Wed Jul 29 21:31:56 2015 -0400
> # Branch stable
> # Node ID a9fa08ce71d4b8f3c567968d2a8986aab64b6524
> # Parent  85785cd3b69f09f2e6ffa78dac75d68d08e400bd
> convert: document convert.hg.startrev
> 
> diff --git a/hgext/convert/__init__.py b/hgext/convert/__init__.py
> --- a/hgext/convert/__init__.py
> +++ b/hgext/convert/__init__.py
> @@ -192,6 +192,9 @@
>         (forces target IDs to change). It takes a boolean argument and
>         defaults to False.
> 
> +    :convert.hg.startrev: specify the initial Mercurial revision number.
> +        The default is 0.
> +

Can this also be a node or revset query, or must it be a number?

>     :convert.hg.revs: revset specifying the source revisions to convert.
> 
>     CVS Source
> diff --git a/tests/test-convert.t b/tests/test-convert.t
> --- a/tests/test-convert.t
> +++ b/tests/test-convert.t
> @@ -143,6 +143,9 @@
>                     store original revision ID in changeset (forces target IDs
>                     to change). It takes a boolean argument and defaults to
>                     False.
> +      convert.hg.startrev
> +                    specify the initial Mercurial revision number. The default
> +                    is 0.
>       convert.hg.revs
>                     revset specifying the source revisions to convert.
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel
Matt Mackall - July 30, 2015, 5:49 p.m.
On Thu, 2015-07-30 at 13:07 -0400, Augie Fackler wrote:
> On Wed, Jul 29, 2015 at 09:47:27PM -0400, Matt Harbison wrote:
> > # HG changeset patch
> > # User Matt Harbison <matt_harbison@yahoo.com>
> > # Date 1438219916 14400
> > #      Wed Jul 29 21:31:56 2015 -0400
> > # Branch stable
> > # Node ID a9fa08ce71d4b8f3c567968d2a8986aab64b6524
> > # Parent  85785cd3b69f09f2e6ffa78dac75d68d08e400bd
> > convert: document convert.hg.startrev
> > 
> > diff --git a/hgext/convert/__init__.py b/hgext/convert/__init__.py
> > --- a/hgext/convert/__init__.py
> > +++ b/hgext/convert/__init__.py
> > @@ -192,6 +192,9 @@
> >         (forces target IDs to change). It takes a boolean argument and
> >         defaults to False.
> > 
> > +    :convert.hg.startrev: specify the initial Mercurial revision number.
> > +        The default is 0.
> > +
> 
> Can this also be a node or revset query, or must it be a number?

Looks like it's any single revision identifier (rev, node, tag,
bookmark, branch), but not a revset.
Matt Mackall - July 30, 2015, 9:35 p.m.
On Wed, 2015-07-29 at 21:47 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1438219916 14400
> #      Wed Jul 29 21:31:56 2015 -0400
> # Branch stable
> # Node ID a9fa08ce71d4b8f3c567968d2a8986aab64b6524
> # Parent  85785cd3b69f09f2e6ffa78dac75d68d08e400bd
> convert: document convert.hg.startrev

Queued for stable, with 'number' dropped, thanks.

> diff --git a/hgext/convert/__init__.py b/hgext/convert/__init__.py
> --- a/hgext/convert/__init__.py
> +++ b/hgext/convert/__init__.py
> @@ -192,6 +192,9 @@
>          (forces target IDs to change). It takes a boolean argument and
>          defaults to False.
>  
> +    :convert.hg.startrev: specify the initial Mercurial revision number.
> +        The default is 0.
> +
>      :convert.hg.revs: revset specifying the source revisions to convert.
>  
>      CVS Source
> diff --git a/tests/test-convert.t b/tests/test-convert.t
> --- a/tests/test-convert.t
> +++ b/tests/test-convert.t
> @@ -143,6 +143,9 @@
>                      store original revision ID in changeset (forces target IDs
>                      to change). It takes a boolean argument and defaults to
>                      False.
> +      convert.hg.startrev
> +                    specify the initial Mercurial revision number. The default
> +                    is 0.
>        convert.hg.revs
>                      revset specifying the source revisions to convert.
>    
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/hgext/convert/__init__.py b/hgext/convert/__init__.py
--- a/hgext/convert/__init__.py
+++ b/hgext/convert/__init__.py
@@ -192,6 +192,9 @@ 
         (forces target IDs to change). It takes a boolean argument and
         defaults to False.
 
+    :convert.hg.startrev: specify the initial Mercurial revision number.
+        The default is 0.
+
     :convert.hg.revs: revset specifying the source revisions to convert.
 
     CVS Source
diff --git a/tests/test-convert.t b/tests/test-convert.t
--- a/tests/test-convert.t
+++ b/tests/test-convert.t
@@ -143,6 +143,9 @@ 
                     store original revision ID in changeset (forces target IDs
                     to change). It takes a boolean argument and defaults to
                     False.
+      convert.hg.startrev
+                    specify the initial Mercurial revision number. The default
+                    is 0.
       convert.hg.revs
                     revset specifying the source revisions to convert.